[GitHub] [tvm] mbaret commented on a change in pull request #8795: [2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op

[GitBox <gi...@apache.org>]

mbaret commented on a change in pull request #8795:
URL: https://github.com/apache/tvm/pull/8795#discussion_r700023373



##########
File path: python/tvm/relay/backend/contrib/ethosu/te/dma.py
##########
@@ -0,0 +1,299 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=invalid-name,unnecessary-lambda
+"""Tensor Expressions for operations supported by the DMA engine"""

Review comment:
       Yeah you're pretty much spot on, the TE we create is very closely coupled to the functionality of our NPU and as such we don't want to rely on existing definitions which may be changed. We need it to remain identical so the TIR matching works and we attach some extra information to the TE (usually in the form of attributes) to ease that process.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org