You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/27 21:17:11 UTC
[GitHub] [arrow-rs] Dandandan commented on a diff in pull request #1861: Faster StringDictionaryBuilder (~60% faster) (#1851)
Dandandan commented on code in PR #1861:
URL: https://github.com/apache/arrow-rs/pull/1861#discussion_r907804661
##########
arrow/Cargo.toml:
##########
@@ -38,13 +38,15 @@ path = "src/lib.rs"
bench = false
[dependencies]
+ahash = { version = "0.7", default-features = false }
Review Comment:
The standaard library includes its own version though (so it won't pull in the same version / dependency as adding the dependency in a project does)
##########
arrow/Cargo.toml:
##########
@@ -38,13 +38,15 @@ path = "src/lib.rs"
bench = false
[dependencies]
+ahash = { version = "0.7", default-features = false }
Review Comment:
The standard library includes its own version though (so it won't pull in the same version / dependency as adding the dependency in a project does)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org