You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/12 14:50:12 UTC

[GitHub] [spark] pengbo edited a comment on issue #24567: [SPARK-27638][SQL]: date format 'yyyy-M-dd' string comparison not handled properly

pengbo edited a comment on issue #24567: [SPARK-27638][SQL]: date format 'yyyy-M-dd' string comparison not handled properly
URL: https://github.com/apache/spark/pull/24567#issuecomment-491130177
 
 
   > > Some corner cases like date_col > 'invalid_date_string' will always return false in this solution seems to be reasonable
   > 
   > It will be super weird if `date_col > 'invalid_date_string'`, `date_col < 'invalid_date_string'` and `date_col = 'invalid_date_string'` all return false. I think returning null is more reasonable.
   
   It returns null indeed. Sorry for any misunderstanding

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org