You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/04/08 02:03:54 UTC
[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request
#45: [TUBEMQ-58] minor update & fix some typos
gosonzhang commented on a change in pull request #45: [TUBEMQ-58] minor update & fix some typos
URL: https://github.com/apache/incubator-tubemq/pull/45#discussion_r405215910
##########
File path: tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/DataConverterUtil.java
##########
@@ -108,17 +108,12 @@
if (info != null) {
info = info.trim();
String[] strInfo = info.split(TokenConstants.SEGMENT_SEP);
- String[] strTopicInfoSet = strInfo[1].split(TokenConstants.ARRAY_SEP);
- for (int i = 0; i < strTopicInfoSet.length; i++) {
- String[] strTopicInfo =
- strTopicInfoSet[i].split(TokenConstants.ATTR_SEP);
- BrokerInfo brokerInfo =
- brokerInfoMap.get(Integer.parseInt(strTopicInfo[0]));
- if (brokerInfo != null) {
- topicList.add(new TopicInfo(brokerInfo,
- strInfo[0], Integer.parseInt(strTopicInfo[1]),
- Integer.parseInt(strTopicInfo[2]), true, true));
- }
+ String[] strTopicInfo = strInfo[1].split(TokenConstants.ATTR_SEP);
Review comment:
There is a problem in this place, the info is actually an array, the content is similar to "topicName TokenConstants.SEGMENT_SEP [[TokenConstants.ARRAY_SEP] brokerId TokenConstants.ATTR_SEP partitionNum TokenConstants.ATTR_SEP topicStoreNum]", if modified in this way,, it will cause the loss of topic metadata
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services