You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/03/07 02:05:20 UTC
[GitHub] [hudi] yihua opened a new pull request, #8108: [HUDI-5883] Avoid throwing error if data table does not exist in Metadata Table Validator
yihua opened a new pull request, #8108:
URL: https://github.com/apache/hudi/pull/8108
### Change Logs
This PR makes the Metadata Table Validator (`HoodieMetadataTableValidator`) to skip the validation of the metadata table if the data table does not exist based on the provided base path, to avoid false positives. A warning message is still printed:
```
23/03/06 17:59:53 WARN HoodieMetadataTableValidator: The Hudi data table is not found: [file:/Users/ethan/Work/tmp/script/123/test_table]. Skipping the validation of the metadata table.
org.apache.hudi.exception.TableNotFoundException: Hoodie table not found in path file:/Users/ethan/Work/tmp/script/123/test_table/.hoodie
at org.apache.hudi.exception.TableNotFoundException.checkTableValidity(TableNotFoundException.java:57)
at org.apache.hudi.common.table.HoodieTableMetaClient.<init>(HoodieTableMetaClient.java:137)
at org.apache.hudi.common.table.HoodieTableMetaClient.newMetaClient(HoodieTableMetaClient.java:689)
at org.apache.hudi.common.table.HoodieTableMetaClient.access$000(HoodieTableMetaClient.java:81)
at org.apache.hudi.common.table.HoodieTableMetaClient$Builder.build(HoodieTableMetaClient.java:770)
at org.apache.hudi.utilities.HoodieMetadataTableValidator.<init>(HoodieMetadataTableValidator.java:180)
at org.apache.hudi.utilities.HoodieMetadataTableValidator.main(HoodieMetadataTableValidator.java:347)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52)
at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:955)
at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:180)
at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:203)
at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:90)
at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:1043)
at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:1052)
at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
Caused by: java.io.FileNotFoundException: File file:/Users/ethan/Work/tmp/script/123/test_table/.hoodie does not exist
at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:779)
at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:1100)
at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:769)
at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:462)
at org.apache.hudi.common.fs.HoodieWrapperFileSystem.lambda$getFileStatus$17(HoodieWrapperFileSystem.java:410)
at org.apache.hudi.common.fs.HoodieWrapperFileSystem.executeFuncWithTimeMetrics(HoodieWrapperFileSystem.java:114)
at org.apache.hudi.common.fs.HoodieWrapperFileSystem.getFileStatus(HoodieWrapperFileSystem.java:404)
at org.apache.hudi.exception.TableNotFoundException.checkTableValidity(TableNotFoundException.java:51)
... 18 more
```
### Impact
Avoids failing the metadata table validation if the data table does not exist. Tested locally that the behavior is expected.
### Risk level
low
### Documentation Update
N/A
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #8108: [HUDI-5883] Avoid throwing error if data table does not exist in Metadata Table Validator
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8108:
URL: https://github.com/apache/hudi/pull/8108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8108: [HUDI-5883] Avoid throwing error if data table does not exist in Metadata Table Validator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8108:
URL: https://github.com/apache/hudi/pull/8108#issuecomment-1457583564
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad58d89e24dcc919c76b89f947404e251ef263c6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15604",
"triggerID" : "ad58d89e24dcc919c76b89f947404e251ef263c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad58d89e24dcc919c76b89f947404e251ef263c6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8108: [HUDI-5883] Avoid throwing error if data table does not exist in Metadata Table Validator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8108:
URL: https://github.com/apache/hudi/pull/8108#issuecomment-1457397225
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad58d89e24dcc919c76b89f947404e251ef263c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad58d89e24dcc919c76b89f947404e251ef263c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad58d89e24dcc919c76b89f947404e251ef263c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8108: [HUDI-5883] Avoid throwing error if data table does not exist in Metadata Table Validator
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8108:
URL: https://github.com/apache/hudi/pull/8108#issuecomment-1457429687
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ad58d89e24dcc919c76b89f947404e251ef263c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15604",
"triggerID" : "ad58d89e24dcc919c76b89f947404e251ef263c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad58d89e24dcc919c76b89f947404e251ef263c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org