[GitHub] vldpyatkov commented on a change in pull request #5887: IGNITE-11023 Processing data bag on GridMarshallerMappingProcessor co…

[GitBox <gi...@apache.org>]

vldpyatkov commented on a change in pull request #5887: IGNITE-11023 Processing data bag on GridMarshallerMappingProcessor co…
URL: https://github.com/apache/ignite/pull/5887#discussion_r250484397
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/MarshallerContextImpl.java
 ##########
 @@ -196,6 +197,11 @@ public void onMappingDataReceived(byte platformId, Map<Integer, MappedName> mars
             int typeId = e.getKey();
             String clsName = e.getValue().className();
 
+            MappedName mappedName = platformCache.get(typeId);
+
+            if (mappedName != null && !F.isEmpty(clsName) && clsName.equals(mappedName.className()))
 
 Review comment:
   @ascherbakoff This logic will not be missed. In case class name on cache does not concur with got class name by discovery full comparison will be performed (with reading class name from file and compare it).
   I have not see need to duplicate the logic again here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services