You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/23 18:10:48 UTC

Re: Review Request 60621: Add new stout capability: os::copyfile.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60621/#review183631
-----------------------------------------------------------




3rdparty/stout/include/stout/os/posix/copyfile.hpp
Lines 26 (patched)
<https://reviews.apache.org/r/60621/#comment259694>

    Not sure how I missed that. Good catch.



3rdparty/stout/include/stout/os/posix/copyfile.hpp
Lines 66 (patched)
<https://reviews.apache.org/r/60621/#comment259697>

    This is odd. I though most of this code was copied from the original implementation (deleted in https://reviews.apache.org/r/60628) but apparently it was changed in the copy. I should have taken a closer look. That does explain why the logging is still here.


- Andrew Schwartzmeyer


On July 3, 2017, 12:29 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60621/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 12:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add new stout capability: os::copyfile.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/Makefile.am 7956d1ae392cd3fa560474bc3ac38877cddce857 
>   3rdparty/stout/include/Makefile.am dec7293949e16b6580509c2fd41a851e349fbef4 
>   3rdparty/stout/include/stout/os/copyfile.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/posix/copyfile.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/copyfile.hpp PRE-CREATION 
>   3rdparty/stout/tests/CMakeLists.txt 8d881ab7ac571dea7aace269332a856feb7a6c43 
>   3rdparty/stout/tests/os/copyfile_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60621/diff/1/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>