You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/02/13 06:26:00 UTC

Review Request 65626: Added mock method for `__run()` in mock slave.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65626/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

Added mock method for `__run()` in mock slave.


Diffs
-----

  src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
  src/tests/mock_slave.hpp 942ead57fc67bdd2a268c67575952349838dc280 
  src/tests/mock_slave.cpp 597d7abef20dd5f89b16e4616233f02760b9d037 


Diff: https://reviews.apache.org/r/65626/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu

Re: Review Request 65626: Added mock method for `__run()` in mock slave.

Posted by Greg Mann <gr...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65626/#review197461
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Feb. 13, 2018, 6:25 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65626/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2018, 6:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mock method for `__run()` in mock slave.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 30151c4886e12e9183a971b86b854e28a8ca1b39 
>   src/tests/mock_slave.hpp 942ead57fc67bdd2a268c67575952349838dc280 
>   src/tests/mock_slave.cpp 597d7abef20dd5f89b16e4616233f02760b9d037 
> 
> 
> Diff: https://reviews.apache.org/r/65626/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>