[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #4225: [ISSUE #3949] Support gRPC protocol

[GitBox <gi...@apache.org>]

lizhanhui commented on code in PR #4225:
URL: https://github.com/apache/rocketmq/pull/4225#discussion_r925096995


##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java:
##########
@@ -210,8 +210,8 @@ public void initChannel(SocketChannel ch) throws Exception {
                             LOGGER.warn("Connections are insecure as SSLContext is null!");
                         }
                     }
-                    pipeline.addLast(
-                        defaultEventExecutorGroup,

Review Comment:
   If null is passed in, the follow-up handlers would be skipped. This is a bug. 
   
   See https://github.com/netty/netty/blob/d34212439068091bcec29a8fad4df82f0a82c638/transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java#L377



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org