You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 08:55:56 UTC
[GitHub] [airflow] ashb opened a new pull request #11274: Access task type via the property, not dundervars
ashb opened a new pull request #11274:
URL: https://github.com/apache/airflow/pull/11274
We don't currently create TIs form serialized dags, but we are about to
start -- at which point some of these cases would have just shown
"SerializedBaseOperator", rather than the _real_ class name.
The other changes are just for "consistency" -- we should always get the
task type from this property, not via `__class__.__name__`.
I haven't set up a pre-commit rule for this as using this dunder
property is used elsewhere on things that are not BaseOperator
instances, and detecting that is hard to do in a pre-commit rule.
---
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11274: Access task type via the property, not dundervars
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11274:
URL: https://github.com/apache/airflow/pull/11274#issuecomment-703498270
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).
You can checks the status of those images in [The workflow run](https://github.com/apache/airflow/actions/runs/289060129)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11274: Access task type via the property, not dundervars
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11274:
URL: https://github.com/apache/airflow/pull/11274#issuecomment-703546473
Unrelated Test failures
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11274: Access task type via the property, not dundervars
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11274:
URL: https://github.com/apache/airflow/pull/11274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org