You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/08 00:21:13 UTC
[GitHub] [druid] maytasm opened a new pull request, #12413: Improve metrics for Auto Compaction
maytasm opened a new pull request, #12413:
URL: https://github.com/apache/druid/pull/12413
Improve metrics for Auto Compaction
### Description
This PR includes the following improvement to Auto Compaction metrics:
- The skip metrics for auto compaction progress (`segment/skipCompact/bytes`, `segment/skipCompact/count`, `interval/skipCompact/count`) previously only include segments skipped due to exceeding Input segment size bytes config. This PR make these metrics now include segments that are skipped due to the Skip offset.
- Include new metrics which express compaction progress (segment byte, number of segment, number of interval) as percentage for easy reading
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a diff in pull request #12413: Improve metrics for Auto Compaction
Posted by GitBox <gi...@apache.org>.
suneet-s commented on code in PR #12413:
URL: https://github.com/apache/druid/pull/12413#discussion_r846303045
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/EmitClusterStatsAndMetrics.java:
##########
@@ -513,5 +515,42 @@ private void emitStatsForCompactSegments(DruidCluster cluster, CoordinatorStats
);
}
);
+
+ // Compute compaction progress as percentage
Review Comment:
Users should be able to compute this from existing metrics. I don't think we need to emit the percentages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm merged pull request #12413: Improve metrics for Auto Compaction
Posted by GitBox <gi...@apache.org>.
maytasm merged PR #12413:
URL: https://github.com/apache/druid/pull/12413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a diff in pull request #12413: Improve metrics for Auto Compaction
Posted by GitBox <gi...@apache.org>.
suneet-s commented on code in PR #12413:
URL: https://github.com/apache/druid/pull/12413#discussion_r846510860
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/EmitClusterStatsAndMetrics.java:
##########
@@ -513,5 +515,42 @@ private void emitStatsForCompactSegments(DruidCluster cluster, CoordinatorStats
);
}
);
+
+ // Compute compaction progress as percentage
Review Comment:
Was removed before my review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org