You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by SimplyY <gi...@git.apache.org> on 2017/11/24 03:02:47 UTC

[GitHub] incubator-weex pull request #909: * [doc] doc references: update weex.config...

GitHub user SimplyY opened a pull request:

    https://github.com/apache/incubator-weex/pull/909

    * [doc] doc references: update weex.config.bundleUrl's description

    weex.config.bundleUrl's description is confused. 
    
    I thinked it is jsUrl without queryString ago.I spent a half of day, finally know bundleUrl is  the same as URL of the page.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SimplyY/incubator-weex patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/909.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #909
    
----
commit 31706217de2d7703a563a8dbd2d8f900b6b7f65d
Author: fengshi.yw <fe...@alibaba-inc.com>
Date:   2017-11-24T02:58:47Z

    * [doc] doc references: update weex.config.bundleUrl's description

----


---

[GitHub] incubator-weex pull request #909: * [doc] doc references: update weex.config...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/909


---

[GitHub] incubator-weex issue #909: * [doc] doc references: update weex.config.bundle...

Posted by acton393 <gi...@git.apache.org>.

Github user acton393 commented on the issue:

    https://github.com/apache/incubator-weex/pull/909
  
    thx for your contribution @SimplyY , it will be accepted and merged, later on.


---

[GitHub] incubator-weex issue #909: * [doc] doc references: update weex.config.bundle...

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/909
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---