You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/22 19:18:45 UTC
[GitHub] [fineract] francisguchie opened a new pull request #1674: FINERACT-1336 add full Parameter List
francisguchie opened a new pull request #1674:
URL: https://github.com/apache/fineract/pull/1674
## Description
Please read here https://issues.apache.org/jira/browse/FINERACT-1336
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1674: FINERACT-1336 add full Parameter List
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1674:
URL: https://github.com/apache/fineract/pull/1674#issuecomment-808795772
The tests probably failed due to some network error..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1674: FINERACT-1336 add full Parameter List
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1674:
URL: https://github.com/apache/fineract/pull/1674#issuecomment-813069447
@josemakara2 I have seen your comments and you have done an extensive job in digging out the trend of the events. My biggest challenge is the way forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1674: FINERACT-1336 add full Parameter List
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1674:
URL: https://github.com/apache/fineract/pull/1674#issuecomment-810603330
@thesmallstar, sure thanks - I it has passed the test now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1674: FINERACT-1336 add full Parameter List
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1674:
URL: https://github.com/apache/fineract/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] josemakara2 commented on pull request #1674: FINERACT-1336 add full Parameter List
Posted by GitBox <gi...@apache.org>.
josemakara2 commented on pull request #1674:
URL: https://github.com/apache/fineract/pull/1674#issuecomment-813031759
Hi @francisguchie Please see comments on Jira FINERACT-1338
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie closed pull request #1674: FINERACT-1336 add full Parameter List
Posted by GitBox <gi...@apache.org>.
francisguchie closed pull request #1674:
URL: https://github.com/apache/fineract/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] francisguchie commented on pull request #1674: FINERACT-1336 add full Parameter List
Posted by GitBox <gi...@apache.org>.
francisguchie commented on pull request #1674:
URL: https://github.com/apache/fineract/pull/1674#issuecomment-813105200
@josemakara2 @thesmallstar
After looking at comments here [FINERACT-1338](https://issues.apache.org/jira/browse/FINERACT-1338)
I tested the PR #1671
This renders this PR useless and thus i will close it thanks to @josemakara2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org