You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/13 11:21:13 UTC
[GitHub] [iceberg] kbendick opened a new pull request #1333: Add all cmmon spark-shell files to gitignore and remove's our assumption that spark-warehouse will only be added to spark folders
kbendick opened a new pull request #1333:
URL: https://github.com/apache/iceberg/pull/1333
If you're like me, you tend to have too many terminals open.
As such, you'll decide to spend some time doing something in `spark-shell` eventually. Maybe you're even fancy and you submit to a remote cluster (in which case this probably won't apply to you unless you set up your spark.eventLog.dir in a fancy way that directs that info back to your local for development purposes.
At the very least, we can probably all agree that the people working on this project are running various forms of spark (and other tools) in the same terminal shels that they're editing and working on the files to the project.
_**TLDRI**_ I found these left over artifacts of old instances of spark-shell had happened in one of my branches, so I took it upon myself to update the `.gitignore` to exclude some of these files.
I also removed the assumption that spark-warehouse would be under a `spark` folder.
I will go through and check that the example doesn't currently have these files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick closed pull request #1333: Add all common spark-shell files to gitignore and remove's our assumption that spark-warehouse will only be added to spark folders
Posted by GitBox <gi...@apache.org>.
kbendick closed pull request #1333:
URL: https://github.com/apache/iceberg/pull/1333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1333: Add all common spark-shell files to gitignore and remove's our assumption that spark-warehouse will only be added to spark folders
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1333:
URL: https://github.com/apache/iceberg/pull/1333#issuecomment-675755175
@kbendick, any idea why there are so many commits in your PRs? Are you branching off of apache/master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1333: Add all common spark-shell files to gitignore and remove's our assumption that spark-warehouse will only be added to spark folders
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1333:
URL: https://github.com/apache/iceberg/pull/1333#issuecomment-675889266
> @kbendick, any idea why there are so many commits in your PRs? Are you branching off of apache/master?
I think you're right. I very obviously messed up somewhere along the way. I'm gonna just open a new PR for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #1333: Add all common spark-shell files to gitignore and remove's our assumption that spark-warehouse will only be added to spark folders
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #1333:
URL: https://github.com/apache/iceberg/pull/1333#discussion_r469884372
##########
File path: .gitignore
##########
@@ -1,6 +1,7 @@
*.swp
.DS_Store
.cache
+**/tmp/
Review comment:
This is to cover any spark directories or other java tmp files people might generate inside the repo during the course of working on one of the many projects we support. It was originally underneath /spark so I assume that a test probably generates it. It will still be ignored this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org