You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2021/12/07 08:51:24 UTC
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18074
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
KUDU-3328: make rebalancer tool take into account maintenance mode
This patch improves rebalancer tool's behavior when some tablet servers are
set maintenance mode. If these tservers are not specified in 'ignored_tservers'
neither, rebalancer couldn't get replica moves and return IllegalState.
Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
---
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
4 files changed, 113 insertions(+), 78 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18074/1
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 4: Code-Review+2
I can't see the Jenkins output (expired), so not sure whether the test failures were related, but LGTM otherwise.
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 18:59:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18074
to look at the new patch set (#4).
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
KUDU-3328: make rebalancer tool take into account maintenance mode
At present kudu master would not assign new replicas on maintenance tservers
but we could still move replicas to them through the rebalancer tool.
Sometimes we want this kind of operation to be disabled because the maintenance
tservers would be restarted or decommissioned in a short time.
This patch improves the rebalancer tool's behavior. If maintenance tservers are
not specified in 'ignored_tservers' and users don't specify
'-force_rebalance_replicas_on_maintenance_tservers' neither, the rebalancer tool
couldn't get replica moves and return IllegalState.
Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
---
M src/kudu/master/auto_rebalancer.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 186 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18074/4
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18074
to look at the new patch set (#2).
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
KUDU-3328: make rebalancer tool take into account maintenance mode
This patch improves rebalancer tool's behavior when some tablet servers are
set maintenance mode.
If users don't specify '--force_rebalance_replicas_on_maintenance_tservers'
and maintenance tservers are not specified in 'ignored_tservers' neither,
rebalancer couldn't get replica moves and return IllegalState.
Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
---
M src/kudu/master/auto_rebalancer.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 182 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18074/2
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 1:
(1 comment)
Overall I think this looks good. Just left some thoughts on overall approach, but I'm leaning to keeping the behavior as implemented in this patch.
Curious if you've given thought to including maintenance mode tservers to the ignored list automatically.
http://gerrit.cloudera.org:8080/#/c/18074/1//COMMIT_MSG
Commit Message:
PS1:
This makes sense because typically maintenance would be used for the sake of a rolling restart, and if the cluster is being restarted, we may not want to be rebalancing, given maintenance mode may shift to another node soon.
Another thought I had was that perhaps we should automatically include maintenance tservers in the list of ignored tservers, though I haven't given it enough thought to decide whether that's a good decision or not. I'd err on the side of ensuring it's clear what the rebalancer is doing, and automatically omitting certain tservers doesn't abide by that principle..
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Dec 2021 20:49:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 3: Verified+1
(5 comments)
Thank you for the improvement!
A few questions and nits.
http://gerrit.cloudera.org:8080/#/c/18074/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18074/3//COMMIT_MSG@15
PS3, Line 15:
It would be great to add small blurb to explain the target use case for this improvement.
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.h
File src/kudu/tools/rebalancer_tool.h:
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.h@100
PS3, Line 100: tablets server
nit: tablet servers
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.cc
File src/kudu/tools/rebalancer_tool.cc:
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.cc@763
PS3, Line 763: server
nit: maybe, use 'tserver' here as well since it's referred to as 'tserver' at item 3.
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc
File src/kudu/tools/tool_action_cluster.cc:
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc@156
PS3, Line 156: force_rebalance_replicas_on_maintenance_tservers
It would be nice to clarify on the behavior of the tool if the following are true:
* a tserver in the maintenance mode
* the tserver is in the --ingnored_tservers list
* --force_rebalance_replicas_on_maintenance_tservers is also specified
What does the tool do with the replicas at that tserver?
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc@159
PS3, Line 159: would be ignored
Any adverse effects when doing so? For example, what happens if a tablet server in the maintenance mode is currently down? Does it make sense to mention some caveats like that to help an operator who runs the rebalancer tool?
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 20 Dec 2021 23:53:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18074
to look at the new patch set (#3).
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
KUDU-3328: make rebalancer tool take into account maintenance mode
This patch improves rebalancer tool's behavior when some tablet servers are
set maintenance mode.
If users don't specify '--force_rebalance_replicas_on_maintenance_tservers'
and maintenance tservers are not specified in 'ignored_tservers' neither,
rebalancer couldn't get replica moves and return IllegalState.
Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
---
M src/kudu/master/auto_rebalancer.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 182 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18074/3
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 4:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/18074/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18074/3//COMMIT_MSG@15
PS3, Line 15: not specified in 'ignored_tservers' and users don't specify
> It would be great to add small blurb to explain the target use case for thi
Done
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.h
File src/kudu/tools/rebalancer_tool.h:
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.h@100
PS3, Line 100: tablets server
> nit: tablet servers
Done
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.cc
File src/kudu/tools/rebalancer_tool.cc:
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/rebalancer_tool.cc@763
PS3, Line 763: tserve
> nit: maybe, use 'tserver' here as well since it's referred to as 'tserver'
Done
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc
File src/kudu/tools/tool_action_cluster.cc:
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc@156
PS3, Line 156: force_rebalance_replicas_on_maintenance_tservers
> It would be nice to clarify on the behavior of the tool if the following ar
In terms of current implementation the sematic of 'ignored_tservers' is stronger than this 'force_...' flag, replicas on the tserver and the tserver itself would be effectively ignored as long as it is specified in 'ignored_tservers'.
http://gerrit.cloudera.org:8080/#/c/18074/3/src/kudu/tools/tool_action_cluster.cc@159
PS3, Line 159: tservers. The si
> Any adverse effects when doing so? For example, what happens if a tablet s
Done
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 21 Dec 2021 07:55:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18074/1//COMMIT_MSG
Commit Message:
PS1:
> Yes, I've thought about just ignoring the maintenance mode servers. The con
Right.
Do you think it would make sense to add some --force_rebalance_tservers_under_maintenance flag or something that lets users opt into it?
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 16 Dec 2021 23:27:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/18074/1//COMMIT_MSG
Commit Message:
PS1:
> Right.
I think it makes sense, just wonder if it makes the tool more complicated. Maybe the error message could be more suggestive.
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 17 Dec 2021 09:24:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18074
to look at the new patch set (#6).
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
KUDU-3328: make rebalancer tool take into account maintenance mode
At present kudu master would not assign new replicas on maintenance tservers
but we could still move replicas to them through the rebalancer tool.
Sometimes we want this kind of operation to be disabled because the maintenance
tservers would be restarted or decommissioned in a short time.
This patch improves the rebalancer tool's behavior. If maintenance tservers are
not specified in 'ignored_tservers' and users don't specify
'-force_rebalance_replicas_on_maintenance_tservers' neither, the rebalancer tool
couldn't get replica moves and return IllegalState.
Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
---
M src/kudu/master/auto_rebalancer.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 163 insertions(+), 97 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18074/6
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 1:
(1 comment)
> Patch Set 1:
>
> (1 comment)
>
> Overall I think this looks good. Just left some thoughts on overall approach, but I'm leaning to keeping the behavior as implemented in this patch.
>
> Curious if you've given thought to including maintenance mode tservers to the ignored list automatically.
http://gerrit.cloudera.org:8080/#/c/18074/1//COMMIT_MSG
Commit Message:
PS1:
> This makes sense because typically maintenance would be used for the sake o
Yes, I've thought about just ignoring the maintenance mode servers. The concern is that we don't know whether users really wants to continue rebalancing in the case, return an error seems doesn't affect anything, if they want to rebalance replicas on the other servers, they could ignore maintenance servers manually.
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 06:57:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
KUDU-3328: make rebalancer tool take into account maintenance mode
At present kudu master would not assign new replicas on maintenance tservers
but we could still move replicas to them through the rebalancer tool.
Sometimes we want this kind of operation to be disabled because the maintenance
tservers would be restarted or decommissioned in a short time.
This patch improves the rebalancer tool's behavior. If maintenance tservers are
not specified in 'ignored_tservers' and users don't specify
'-force_rebalance_replicas_on_maintenance_tservers' neither, the rebalancer tool
couldn't get replica moves and return IllegalState.
Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Reviewed-on: http://gerrit.cloudera.org:8080/18074
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/master/auto_rebalancer.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 163 insertions(+), 97 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 7
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18074
to look at the new patch set (#5).
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
KUDU-3328: make rebalancer tool take into account maintenance mode
At present kudu master would not assign new replicas on maintenance tservers
but we could still move replicas to them through the rebalancer tool.
Sometimes we want this kind of operation to be disabled because the maintenance
tservers would be restarted or decommissioned in a short time.
This patch improves the rebalancer tool's behavior. If maintenance tservers are
not specified in 'ignored_tservers' and users don't specify
'-force_rebalance_replicas_on_maintenance_tservers' neither, the rebalancer tool
couldn't get replica moves and return IllegalState.
Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
---
M src/kudu/master/auto_rebalancer.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/rebalance/rebalancer.h
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/rebalancer_tool.h
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 163 insertions(+), 93 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/18074/5
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3328: make rebalancer tool take into account maintenance mode
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18074 )
Change subject: KUDU-3328: make rebalancer tool take into account maintenance mode
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I843a2521a811ab67c5f98bb43cc84367edb3fe0b
Gerrit-Change-Number: 18074
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 05 Jan 2022 19:02:07 +0000
Gerrit-HasComments: No