You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/10/29 18:14:11 UTC
Review Request 71696: Updated validation of 'Reserve' call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71696/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9985
https://issues.apache.org/jira/browse/MESOS-9985
Repository: mesos
Description
-------
Updated `master::validation::operation::validate(Reserve&)` to
account for the new `source` field in the reserve call, verifying
that `source` and `resources` have a common reservation ancestor.
Diffs
-----
src/master/validation.cpp a7ecefb8a1e186901301419feca75600d8de001b
Diff: https://reviews.apache.org/r/71696/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71696: Updated validation of 'Reserve' call.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71696/#review218534
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Nov. 5, 2019, 2:25 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71696/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2019, 2:25 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9985
> https://issues.apache.org/jira/browse/MESOS-9985
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `master::validation::operation::validate(Reserve&)` to
> account for the new `source` field in the reserve call, verifying
> that `source` and `resources` have a common reservation ancestor.
>
>
> Diffs
> -----
>
> src/master/validation.cpp a7ecefb8a1e186901301419feca75600d8de001b
>
>
> Diff: https://reviews.apache.org/r/71696/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71696: Updated validation of 'Reserve' call.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71696/
-----------------------------------------------------------
(Updated Nov. 5, 2019, 1:25 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Incorporated fixups by @bbannier.
Bugs: MESOS-9985
https://issues.apache.org/jira/browse/MESOS-9985
Repository: mesos
Description
-------
Updated `master::validation::operation::validate(Reserve&)` to
account for the new `source` field in the reserve call, verifying
that `source` and `resources` have a common reservation ancestor.
Diffs (updated)
-----
src/master/validation.cpp a7ecefb8a1e186901301419feca75600d8de001b
Diff: https://reviews.apache.org/r/71696/diff/2/
Changes: https://reviews.apache.org/r/71696/diff/1-2/
Testing
-------
Thanks,
Benno Evers