You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/31 18:06:23 UTC

[GitHub] [druid] gianm commented on issue #9296: Allow HdfsDataSegmentKiller to be instantiated without storageDirectory set.

gianm commented on issue #9296: Allow HdfsDataSegmentKiller to be instantiated without storageDirectory set.
URL: https://github.com/apache/druid/pull/9296#issuecomment-580844275
 
 
   > Now I'm wondering if it makes more sense to put all non-core inputSources in the same extension rather than having them in different extensions. A druid cluster can have only one deep storage, but it should be able to read from different input sources which means people need to choose and load multiple extensions based on where they want to ingest from. I'm not sure what's the disadvantage of having such a consolidated input source extension though except the compatibility when they upgrade their cluster.
   
   The advantage is just dependency hygiene, I guess. It's nice to not load the entire world if you aren't going to use it (some of these input sources pull in big sets of dependencies, like hdfs). But the advantage is it would be easier to use (no need to choose which extensions to load).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org