[jira] [Comment Edited] (IGNITE-2404) TcpDiscoverySpi.setLocalPortRange set 0 doesn't work

["Denis Magda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206043#comment-15206043 ] 

Denis Magda edited comment on IGNITE-2404 at 3/22/16 9:19 AM:
--------------------------------------------------------------

[~ryanzhaocs],

I've reviewed your changes and left my comments directly in the pull-request.

As per IgniteConfiguration#getTimeServerPortRange and ConnectorConfiguration#getPortRange let's make sure that port range set to '0' will work with them as well. To achieve this you can modify the loops where these ranges are used in a way I recommended to do for TcpDiscoverySpi in the pull-request (only variables will have different names)

{noformat}
int lastPort = spi.locPortRange == 0 ? spi.locPort : spi.locPort + spi.locPortRange - 1;

for (port = spi.locPort; port <= lasPort; port++)
{noformat}


was (Author: dmagda):
[~ryanzhaocs],

I've reviewed your changes and left my comments directly in the pull-request.

As per IgniteConfiguration#getTimeServerPortRange and ConnectorConfiguration#getPortRange let's make sure that port range set to '0' will work with them as well. To achieve this you can modify the loops where these ranges are used in a way I recommended to do for TcpDiscoverySpi in the pull-request

{noformat}
int lastPort = spi.locPortRange == 0 ? spi.locPort : spi.locPort + spi.locPortRange - 1;

for (port = spi.locPort; port <= lasPort; port++)
{noformat}

> TcpDiscoverySpi.setLocalPortRange set  0 doesn't work
> -----------------------------------------------------
>
>                 Key: IGNITE-2404
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2404
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Denis Magda
>            Assignee: Ryan Zhao
>              Labels: community, newbie
>
> Local port range set to 0 presently doesn't work at least for TcpCommunicationSpi and TcpDiscoverySpi. However SPIs support it.
> In my understanding the condition has to changed to the following one (from < to <=).
> x = port; x <= port + range



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)