[GitHub] [flink] PatrickRen commented on a diff in pull request #21065: [FLINK-29567][connector/common] Change numRecordsSend / numBytesSend / numRecordsSendError back to numRecordsOut / numBytesOut / numRecordsOutError in sink

[GitBox <gi...@apache.org>]

PatrickRen commented on code in PR #21065:
URL: https://github.com/apache/flink/pull/21065#discussion_r997906032


##########
flink-connectors/flink-connector-aws-kinesis-firehose/src/main/java/org/apache/flink/connector/firehose/sink/KinesisFirehoseSinkWriter.java:
##########
@@ -96,11 +96,7 @@ private static FirehoseAsyncClient createFirehoseClient(
                     RESOURCE_NOT_FOUND_EXCEPTION_CLASSIFIER,
                     getSdkClientMisconfiguredExceptionClassifier());
 
-    // deprecated, use numRecordsSendErrorsCounter instead.
-    @Deprecated private final Counter numRecordsOutErrorsCounter;
-
-    /* A counter for the total number of records that have encountered an error during put */
-    private final Counter numRecordsSendErrorsCounter;

Review Comment:
   `numRecordsSend` and `numRecordsSendErrors` are registered in `InternalSinkWriterMetricGroup` using the same counter of `numRecordsOut` and `numRecordsOutErrors`, in order to make these metrics having the same value. Thus we only need to keep one counter in the sink writer implementation. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org