[GitHub] activemq-artemis issue #1461: ARTEMIS-1348 Support LVQ for AMQP

[tabish121 <gi...@git.apache.org>]

Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1461
  
    This approach has a couple of negatives going for it.  
    
    First the use of application properties for message handling directives now requires that every incoming message will have to decode that section of the message where previously the broker attempted to not do so unless needed as there is significant overhead in the decode.
    
    Second the LVQ property applied to the sent message is now carried on the outbound message which may confuse those who aren't expecting that property in the messages received, I think the core JMS client filters these out in getPropertyNames JMS APIs but I could be wrong, Qpid JMS certainly would not.  In any case it's odd that a routing directive is propagate all the way to the receiving client, these sorts of things are known to cause issues when the message is retransmitted or hops around a broker network.  
    
    This would be better slotted in as a Message Annotation or maybe even a Delivery Annotation, would need some more thought to determine which is the right place.   In general the Application Properties of an AMQP message do not carry directives for the peer.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---