[GitHub] [airflow] sydykov commented on a diff in pull request #27616: Flush the session in `handle_failure()` prior to invoking callbacks

[GitBox <gi...@apache.org>]

sydykov commented on code in PR #27616:
URL: https://github.com/apache/airflow/pull/27616#discussion_r1059296335


##########
airflow/models/taskinstance.py:
##########
@@ -1808,13 +1808,13 @@ def handle_failure(
             except Exception:
                 self.log.exception("Failed to send email to: %s", task.email)
 
-        if callback and context:
-            self._run_finished_callback(callback, context, callback_type)
-
         if not test_mode:
             session.merge(self)
             session.flush()
 
+        if callback and context:
+            self._run_finished_callback(callback, context, callback_type)
+

Review Comment:
   @ephraimbuddy, hi! I am planning to get back to this in January. Thank you for asking, and I regret delaying the PR this much.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org