You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/12/03 17:58:26 UTC
[GitHub] [incubator-daffodil] olabusayoT opened a new pull request #464: Fixes sonarcloud duplication error
olabusayoT opened a new pull request #464:
URL: https://github.com/apache/incubator-daffodil/pull/464
Sonarcloud is currently failing due to the sapi/japi and Main.scala code exceeding the duplication threshold. We add sapi/japi directories and Main.scala to cpd exclusions list so duplication checks are not done on them.
I was not able to replicate the failure state on my local instance, so this PR technically was not tested for the fix. It was tested to ensure a valid check could be run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] stevedlawrence commented on pull request #464: Fixes sonarcloud duplication error
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on pull request #464:
URL: https://github.com/apache/incubator-daffodil/pull/464#issuecomment-738196171
+1 Only suggestion is to add a bug number to the commit message, I think DAFFODIL-2275 is reasonable--not sure this needs a new bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] olabusayoT merged pull request #464: Fixes sonarcloud duplication error
Posted by GitBox <gi...@apache.org>.
olabusayoT merged pull request #464:
URL: https://github.com/apache/incubator-daffodil/pull/464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-daffodil] olabusayoT commented on pull request #464: Fixes sonarcloud duplication error
Posted by GitBox <gi...@apache.org>.
olabusayoT commented on pull request #464:
URL: https://github.com/apache/incubator-daffodil/pull/464#issuecomment-738861658
This change does nothing to affect codecoverage so we are merging it despite the failing codecov/project check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org