You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/04 05:52:51 UTC

[PR] fix(ai): require cluster in dashboard summary tool [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3126:
URL: https://github.com/apache/rocketmq-dashboard/pull/3126

   ### Summary
   Guard and cover the AI dashboard-summary tool handler:
   
   - `DashboardSummaryToolHandler.execute` now rejects a null input (`tool input is required`) and a missing/blank `cluster` (`cluster is required`) with clear 400s, instead of NPE-ing on `input.get` or on `clusterId.equals(...)` during filtering.
   - New `DashboardSummaryToolHandlerTest` (first coverage) verifies both guards and the cluster/stats projection happy path.
   
   ### Why
   Tool handlers run on LLM-produced inputs and had no automated coverage; both null and missing-cluster inputs previously crashed opaquely.
   
   ### Testing
   - `mvn -f server/pom.xml -Dtest=DashboardSummaryToolHandlerTest test` passes: 3/3.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ai): require cluster in dashboard summary tool [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3126: fix(ai): require cluster in dashboard summary tool
URL: https://github.com/apache/rocketmq-dashboard/pull/3126


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org