[GitHub] [singa] nudles commented on pull request #761: C++ build with Github Actions

[GitBox <gi...@apache.org>]

nudles commented on pull request #761:
URL: https://github.com/apache/singa/pull/761#issuecomment-657314106


   > 
   > 
   > The team may discuss and decide when should we run the C++ build action. In this example, I assume we run it on push and pull requests on Master and Dev branches. But of course this can be changed if the team prefers other options.
   > 
   > Currently it tests the build on latest ubuntu, we can also build on previous versions of ubuntu if needed. but it can be too much for each pull request. what do you think? may be the complete test against all the versions of ubuntu can be enabled on the Master branch only, while a quick test on the latest ubuntu can be done with each pull request on dev? or on all branches except Master?
   
   +1.
   
   > 
   > We also need to run the C++ and Python tests. However both of them fail now and if I add them here, they fail the Github check. The C++ test error can be found [here](https://github.com/moazreyad/singa/runs/855402800?check_suite_focus=true#step:6:98). Can anyone fix this error and make sure that the C++ test passes before we add it to this workflow of the Github Action? The problem happens when we compile SINGA with ENABLE_TEST=ON, and run the unit tests by ./bin/test_singa
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org