You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/27 10:56:17 UTC
[GitHub] [doris] englefly opened a new pull request, #11262: [feature] (Nereids) add rule to merge consecutive project nodes
englefly opened a new pull request, #11262:
URL: https://github.com/apache/doris/pull/11262
# Proposed changes
Merge consecutive project nodes. For example:
logical plan tree:
```
project(a)
|
project(a,b)
|
project(a, b, c)
|
scan
```
transformed to:
```
project(a)
|
scan
```
Issue Number: close #xxx
## Problem Summary:
## Checklist(Required)
1. Type of your changes:
- [ ] Improvement
- [ ] Fix
- [ ] Feature-WIP
- [ ] Feature
- [ ] Doc
- [ ] Refator
- [ ] Others:
2. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11262:
URL: https://github.com/apache/doris/pull/11262#discussion_r931015591
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveProjects.java:
##########
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project(a)
+ * |
+ * project(a,b)
+ * |
+ * project(a, b, c)
+ * |
+ * scan
+ * transformed to:
+ * project(a)
+ * |
+ * scan
+ */
+
+public class MergeConsecutiveProjects extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalProject(logicalProject()).then(project -> {
+ LogicalProject childProject = project.child();
+ return new LogicalProject(project.getProjects(), (Plan) childProject.children().get(0));
Review Comment:
we need to handle this:
```
Project((func1(#3))#5, func2(#4)#6)
|---Project((a#1 + 1)#3, (b#2 - 1)#4)
|---OlapScan(a#1, b#2)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 merged pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
924060929 merged PR #11262:
URL: https://github.com/apache/doris/pull/11262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11262:
URL: https://github.com/apache/doris/pull/11262#discussion_r932134296
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveProjects.java:
##########
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.ExprId;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.expressions.visitor.IterationVisitor;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project(a)
+ * |
+ * project(a,b)
+ * |
+ * project(a, b, c)
+ * |
+ * scan
+ * transformed to:
+ * project(a)
+ * |
+ * scan
+ */
+
+public class MergeConsecutiveProjects extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalProject(logicalProject()).then(project -> {
+ List<NamedExpression> projectExpressions = project.getProjects();
+ LogicalProject childProject = project.child();
+ List<NamedExpression> childProjectExpressions = childProject.getProjects();
+ HashMap<ExprId, Alias> childAliasMap = new HashMap<ExprId, Alias>();
+ AliasExtractor extractor = new AliasExtractor();
+ for (NamedExpression expression : childProjectExpressions) {
+ extractor.visit(expression, childAliasMap);
+ }
+ ExpressionReplacer replacer =
+ new ExpressionReplacer<Map<ExprId, Alias>>();
+ projectExpressions = projectExpressions.stream()
+ .map(e -> replacer.visit(e, childAliasMap))
+ .map(NamedExpression.class::cast)
+ .collect(Collectors.toList());
+ return new LogicalProject(projectExpressions, (Plan) childProject.children().get(0));
+ }).toRule(RuleType.MERGE_CONSECUTIVE_PROJECTS);
+ }
+
+ private class ExpressionReplacer<M>
Review Comment:
move out ExpressionReplacer from AggregateDisassemble to tree/expressions/visitor and use it here
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveProjects.java:
##########
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.ExprId;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.expressions.visitor.IterationVisitor;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project(a)
+ * |
+ * project(a,b)
+ * |
+ * project(a, b, c)
+ * |
+ * scan
+ * transformed to:
+ * project(a)
+ * |
+ * scan
+ */
+
+public class MergeConsecutiveProjects extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalProject(logicalProject()).then(project -> {
+ List<NamedExpression> projectExpressions = project.getProjects();
+ LogicalProject childProject = project.child();
+ List<NamedExpression> childProjectExpressions = childProject.getProjects();
+ HashMap<ExprId, Alias> childAliasMap = new HashMap<ExprId, Alias>();
+ AliasExtractor extractor = new AliasExtractor();
+ for (NamedExpression expression : childProjectExpressions) {
+ extractor.visit(expression, childAliasMap);
+ }
Review Comment:
```suggestion
Map<Expression, Expression> sMap = childProjectExpressions.stream().collect(Collectors.toMap(
NamedExpression::toSlot, e -> e instanceof SlotReference ? e : e.child(0)));
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveProjects.java:
##########
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.ExprId;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.expressions.visitor.IterationVisitor;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project(a)
+ * |
+ * project(a,b)
+ * |
+ * project(a, b, c)
+ * |
+ * scan
+ * transformed to:
+ * project(a)
+ * |
+ * scan
+ */
+
+public class MergeConsecutiveProjects extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalProject(logicalProject()).then(project -> {
+ List<NamedExpression> projectExpressions = project.getProjects();
+ LogicalProject childProject = project.child();
Review Comment:
```suggestion
LogicalProject<GroupPlan> childProject = project.child();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11262:
URL: https://github.com/apache/doris/pull/11262#issuecomment-1202049760
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #11262:
URL: https://github.com/apache/doris/pull/11262#discussion_r934329212
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ExpressionReplacer.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.visitor;
+
+import org.apache.doris.nereids.trees.expressions.Expression;
+
+import java.util.Map;
+
+/**
+ * replace expr nodes by substitutionMap
+ */
+public class ExpressionReplacer
+ extends DefaultExpressionRewriter<Map<Expression, Expression>> {
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11262:
URL: https://github.com/apache/doris/pull/11262#discussion_r934285282
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ExpressionReplacer.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.visitor;
+
+import org.apache.doris.nereids.trees.expressions.Expression;
+
+import java.util.Map;
+
+/**
+ * replace expr nodes by substitutionMap
+ */
+public class ExpressionReplacer
+ extends DefaultExpressionRewriter<Map<Expression, Expression>> {
Review Comment:
add singleton back
```
private static final ExpressionReplacer INSTANCE = new ExpressionReplacer();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11262:
URL: https://github.com/apache/doris/pull/11262#issuecomment-1201953287
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #11262:
URL: https://github.com/apache/doris/pull/11262#discussion_r934085615
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MergeConsecutiveProjects.java:
##########
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.ExprId;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.expressions.visitor.DefaultExpressionRewriter;
+import org.apache.doris.nereids.trees.expressions.visitor.IterationVisitor;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+/**
+ * this rule aims to merge consecutive filters.
+ * For example:
+ * logical plan tree:
+ * project(a)
+ * |
+ * project(a,b)
+ * |
+ * project(a, b, c)
+ * |
+ * scan
+ * transformed to:
+ * project(a)
+ * |
+ * scan
+ */
+
+public class MergeConsecutiveProjects extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalProject(logicalProject()).then(project -> {
+ List<NamedExpression> projectExpressions = project.getProjects();
+ LogicalProject childProject = project.child();
+ List<NamedExpression> childProjectExpressions = childProject.getProjects();
+ HashMap<ExprId, Alias> childAliasMap = new HashMap<ExprId, Alias>();
+ AliasExtractor extractor = new AliasExtractor();
+ for (NamedExpression expression : childProjectExpressions) {
+ extractor.visit(expression, childAliasMap);
+ }
+ ExpressionReplacer replacer =
+ new ExpressionReplacer<Map<ExprId, Alias>>();
+ projectExpressions = projectExpressions.stream()
+ .map(e -> replacer.visit(e, childAliasMap))
+ .map(NamedExpression.class::cast)
+ .collect(Collectors.toList());
+ return new LogicalProject(projectExpressions, (Plan) childProject.children().get(0));
+ }).toRule(RuleType.MERGE_CONSECUTIVE_PROJECTS);
+ }
+
+ private class ExpressionReplacer<M>
Review Comment:
They have different logical.
In this case, the key is ExprId, while in AggregateDisassemble the key is expression.
Comparison by exprId is more efficient than comparison by expression tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #11262: [feature] (Nereids) add rule to merge consecutive project nodes
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #11262:
URL: https://github.com/apache/doris/pull/11262#discussion_r934337549
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ExpressionReplacer.java:
##########
@@ -0,0 +1,38 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.visitor;
+
+import org.apache.doris.nereids.trees.expressions.Expression;
+
+import java.util.Map;
+
+/**
+ * replace expr nodes by substitutionMap
+ */
+public class ExpressionReplacer
+ extends DefaultExpressionRewriter<Map<Expression, Expression>> {
Review Comment:
done
but it is public now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org