You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Beyene, Mehari" <me...@amazon.com.INVALID> on 2023/06/16 15:55:38 UTC
[VOTE] KIP-937: Improve Message Timestamp Validation
Hello everyone,
I am opening the Volte on KIP-937 here. If we have more to discuss, please continue the discussion on the existing thread at: https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdlx3kc1g5zczc
Thank you,
Mehari
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by "Beyene, Mehari" <me...@amazon.com.INVALID>.
Hi all,
I would like thank you all of you for participating in the voting process. After being open for 11 days, we have received the necessary votes to proceed, and I am now closing the voting process. KIP-937 has been accepted with 3 binding votes from Luke Chen, Divij Vaidya, and Justine Olshan, along with 3 non-binding votes from Kirk True, Andrew Schofield, and Christo Lolov.
Thank you,
Mehari
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by Justine Olshan <jo...@confluent.io.INVALID>.
Hey Mehari,
Yes. The KIP looks good to me. +1 (binding)
Justine
On Tue, Jun 27, 2023 at 12:13 PM Beyene, Mehari <me...@amazon.com.invalid>
wrote:
> Hi Justine/All,
>
> I want to wrap up this voting process in the next day or so. Justine,
> since you gave a conditional binding vote regarding updating the error
> message, I want to circle back and verify that you're happy with the
> current state of the changes before concluding the voting process.
>
> Thanks,
> Mehari
>
>
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by "Beyene, Mehari" <me...@amazon.com.INVALID>.
Hi Justine/All,
I want to wrap up this voting process in the next day or so. Justine, since you gave a conditional binding vote regarding updating the error message, I want to circle back and verify that you're happy with the current state of the changes before concluding the voting process.
Thanks,
Mehari
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by Christo Lolov <ch...@gmail.com>.
+1 (non-binding) from me as well! This is the type of problem which is
difficult to become aware of so the more guardrails we put into place the
better.
On Wed, 21 Jun 2023 at 23:30, Beyene, Mehari <me...@amazon.com.invalid>
wrote:
> Thank you, Justin. That makes sense.
> I have updated the KIP to remove the concept of ahead/behind. Instead, we
> will use the existing error message that utilizes the acceptable range for
> the timestamps.
>
> Thanks,
> Mehari
>
>
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by "Beyene, Mehari" <me...@amazon.com.INVALID>.
Thank you, Justin. That makes sense.
I have updated the KIP to remove the concept of ahead/behind. Instead, we will use the existing error message that utilizes the acceptable range for the timestamps.
Thanks,
Mehari
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by Justine Olshan <jo...@confluent.io.INVALID>.
Hey Mehari,
Thanks for the KIP. One minor change is now that we have the before and
after configs does this error make sense?
> we will return error code 32 (INVALID_TIMESTAMP) with the error message
"Timestamp of the message with offset [record offset] is ahead of the
broker's current time."
I think maybe we should either say ahead/behind, or remove that aspect of
the message. Other than that, the change seems reasonable.
Given a clearer error, +1 from me (binding)
Thanks,
Justine
On Tue, Jun 20, 2023 at 1:28 AM Andrew Schofield <
andrew_schofield_jira@outlook.com> wrote:
> +1 (non-binding).
>
> Thanks,
> Andrew
>
> > On 19 Jun 2023, at 11:42, Divij Vaidya <di...@gmail.com> wrote:
> >
> > This KIP solves a real operational pain point for the administrator of
> > Kafka cluster.
> >
> > +1 (binding)
> >
> > --
> > Divij Vaidya
> >
> >
> >
> > On Sun, Jun 18, 2023 at 5:09 AM Kirk True <ki...@kirktrue.pro> wrote:
> >
> >> +1 (non-binding)
> >>
> >> Thanks Mehari!
> >>
> >>> On Jun 16, 2023, at 6:29 PM, Luke Chen <sh...@gmail.com> wrote:
> >>>
> >>> +1 (binding) from me.
> >>>
> >>> Thanks.
> >>> Luke
> >>>
> >>> On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari
> >> <me...@amazon.com.invalid>
> >>> wrote:
> >>>
> >>>> Hello everyone,
> >>>>
> >>>> I am opening the Volte on KIP-937 here. If we have more to discuss,
> >> please
> >>>> continue the discussion on the existing thread at:
> >>>> https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdlx3kc1g5zczc
> >>>>
> >>>> Thank you,
> >>>> Mehari
> >>>>
> >>>>
> >>
> >>
>
>
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by Andrew Schofield <an...@outlook.com>.
+1 (non-binding).
Thanks,
Andrew
> On 19 Jun 2023, at 11:42, Divij Vaidya <di...@gmail.com> wrote:
>
> This KIP solves a real operational pain point for the administrator of
> Kafka cluster.
>
> +1 (binding)
>
> --
> Divij Vaidya
>
>
>
> On Sun, Jun 18, 2023 at 5:09 AM Kirk True <ki...@kirktrue.pro> wrote:
>
>> +1 (non-binding)
>>
>> Thanks Mehari!
>>
>>> On Jun 16, 2023, at 6:29 PM, Luke Chen <sh...@gmail.com> wrote:
>>>
>>> +1 (binding) from me.
>>>
>>> Thanks.
>>> Luke
>>>
>>> On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari
>> <me...@amazon.com.invalid>
>>> wrote:
>>>
>>>> Hello everyone,
>>>>
>>>> I am opening the Volte on KIP-937 here. If we have more to discuss,
>> please
>>>> continue the discussion on the existing thread at:
>>>> https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdlx3kc1g5zczc
>>>>
>>>> Thank you,
>>>> Mehari
>>>>
>>>>
>>
>>
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by Divij Vaidya <di...@gmail.com>.
This KIP solves a real operational pain point for the administrator of
Kafka cluster.
+1 (binding)
--
Divij Vaidya
On Sun, Jun 18, 2023 at 5:09 AM Kirk True <ki...@kirktrue.pro> wrote:
> +1 (non-binding)
>
> Thanks Mehari!
>
> > On Jun 16, 2023, at 6:29 PM, Luke Chen <sh...@gmail.com> wrote:
> >
> > +1 (binding) from me.
> >
> > Thanks.
> > Luke
> >
> > On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari
> <me...@amazon.com.invalid>
> > wrote:
> >
> >> Hello everyone,
> >>
> >> I am opening the Volte on KIP-937 here. If we have more to discuss,
> please
> >> continue the discussion on the existing thread at:
> >> https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdlx3kc1g5zczc
> >>
> >> Thank you,
> >> Mehari
> >>
> >>
>
>
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by Kirk True <ki...@kirktrue.pro>.
+1 (non-binding)
Thanks Mehari!
> On Jun 16, 2023, at 6:29 PM, Luke Chen <sh...@gmail.com> wrote:
>
> +1 (binding) from me.
>
> Thanks.
> Luke
>
> On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari <me...@amazon.com.invalid>
> wrote:
>
>> Hello everyone,
>>
>> I am opening the Volte on KIP-937 here. If we have more to discuss, please
>> continue the discussion on the existing thread at:
>> https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdlx3kc1g5zczc
>>
>> Thank you,
>> Mehari
>>
>>
Re: [VOTE] KIP-937: Improve Message Timestamp Validation
Posted by Luke Chen <sh...@gmail.com>.
+1 (binding) from me.
Thanks.
Luke
On Fri, Jun 16, 2023 at 11:55 PM Beyene, Mehari <me...@amazon.com.invalid>
wrote:
> Hello everyone,
>
> I am opening the Volte on KIP-937 here. If we have more to discuss, please
> continue the discussion on the existing thread at:
> https://lists.apache.org/thread/wdpw845q9f5rhf6tz9tdlx3kc1g5zczc
>
> Thank you,
> Mehari
>
>