You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Andrey N. Gura (Jira)" <ji...@apache.org> on 2021/09/21 10:56:00 UTC
[jira] [Commented] (IGNITE-15441) [Ignite 3] Fix Errorprone errors
in Metastore-server module
[ https://issues.apache.org/jira/browse/IGNITE-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418040#comment-17418040 ]
Andrey N. Gura commented on IGNITE-15441:
-----------------------------------------
[~amashenkov] No. I just believe that such kind of checks are useless because there are a lot of cases when you can just ignore returned value.
> [Ignite 3] Fix Errorprone errors in Metastore-server module
> -----------------------------------------------------------
>
> Key: IGNITE-15441
> URL: https://issues.apache.org/jira/browse/IGNITE-15441
> Project: Ignite
> Issue Type: Bug
> Reporter: Andrey Mashenkov
> Assignee: Andrey N. Gura
> Priority: Minor
> Labels: ignite-3
> Fix For: 3.0.0-alpha3
>
>
> Static analyzer tool Errorprone reports errors for few modules.
> These errors are muted and must be fixed.
> {code:java}
> See parent/pom.xml -> Maven compiler plugin configuration -> compiler argument "XepExcludedPaths:"
> {code}
> Let's fix errors and unmute error-prone for Metastorage-server module.
> {code:java}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project ignite-metastorage-server: Compilation failure
> [ERROR] ....apache-ignite-3/modules/metastorage-server/src/main/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java:[667,40] [ReturnValueIgnored] Return value of 'hasNext' must be used
> [ERROR] (see https://errorprone.info/bugpattern/ReturnValueIgnored)
> [ERROR] Did you mean to remove this line?
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)