You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by Anatole Tresch <at...@gmail.com> on 2019/09/10 22:52:46 UTC
[Result][VOTE] Release of Apache Tamaya 0.4-incubating-RC3
I will close this vote again with a NO result, let's do another try - stay
tuned and happy ;-)
Am Do., 5. Sept. 2019 um 09:35 Uhr schrieb Julian Feinauer <
j.feinauer@pragmaticminds.de>:
> Hi all,
>
> sorry for the late reply.
> I just checked the release.
>
> Sadly, I have to vote
>
> -1 (binding)
>
> as the Signatures that were used to sign the artefacts in extensions
> module are NOT in the keys file and thus cant be checked : /
>
> Furthermore, if trying to build apiandcore (as explained in README) I get
>
> Unrecognized VM option 'PermGenSpace=200m'
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
>
> On OS X with
> - mvn
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T21:00:29+02:00)
> - java
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
> which should also be compliant due to README.
>
> If I disable PermGenSpace then I am able to build both modules
> successfully.
> So I would just delete that form the readme, than it should be fine.
> I think those issues are rather "minor" and not blocking.
>
> Furthermore I checked:
> - Signature is okay for apiandcore
> - No Hash is present (I think that’s okay?!) but it would be good to have
> sha hashes
> - NOTICE, LICENCE and DISCLAIMER look good
> - I found several files without License header (see below). Most of these
> are okay but I would check the bnd files
> - No unexpected binaries
>
> So although I have to downvote the release it looks pretty good and I
> think there are only some small changes necessary to make it pass.
>
> Julian
>
> # Appendix: Files without License header (rat output):
>
> ## Apiandcore
> 24 ./.travis.yml
> 25 ./README.md
> 26 ./maturity-model.md
> 28 ./running-mutation-tests.adoc
> 29 ./code/api/bnd.bnd
> 30 ./code/core/bnd.bnd
> 31 ./code/core/src/test/resources/java-security.policy
> 32 ./code/spi-support/bnd.bnd
> 33 ./readme/ReleaseNotes-0.1-incubating.html
> 34 ./readme/ReleaseNotes-0.2-incubating.html
> 35 ./readme/ReleaseNotes-0.3-incubating.html
> 36 ./readme/ReleaseNotes-0.4-incubating.html
>
> ## Extensions
> 24 ./.travis.yml
> 25 ./README.md
> 28 ./running-mutation-tests.adoc
> 29 ./examples/02-resolver-example/src/main/resources/build.data
> 30 ./examples/05-spring-example/README.md
> 31 ./modules/collections/bnd.bnd
> 32 ./modules/consul/bnd.bnd
> 33 ./modules/etcd/bnd.bnd
> 34 ./modules/etcd/nbactions.xml
> 35 ./modules/events/bnd.bnd
> 36 ./modules/features/bnd.bnd
> 37 ./modules/filter/bnd.bnd
> 38 ./modules/formats/base/bnd.bnd
> 39 ./modules/formats/hocon/bnd.bnd
> 40 ./modules/formats/json/bnd.bnd
> 41 ./modules/formats/yaml/bnd.bnd
> 42 ./modules/functions/bnd.bnd
> 43 ./modules/hazelcast/bnd.bnd
> 44 ./modules/injection/cdi/bnd.bnd
> 45 ./modules/injection/injection-api/bnd.bnd
> 46 ./modules/injection/standalone/bnd.bnd
> 47 ./modules/jndi/bnd.bnd
> 48 ./modules/microprofile/bnd.bnd
> 49 ./modules/mutable-config/bnd.bnd
> 50 ./modules/optional/bnd.bnd
> 51 ./modules/osgi/common/bnd.bnd
> 52 ./modules/osgi/gogo-shell/bnd.bnd
> 53 ./modules/osgi/injection/bnd.bnd
> 54 ./modules/osgi/karaf-shell/bnd.bnd
> 55 ./modules/osgi/updater/bnd.bnd
> 56 ./modules/resolver/bnd.bnd
> 57 ./modules/resources/README.md
> 58 ./modules/resources/bnd.bnd
> 59 ./modules/spring/bnd.bnd
>
>
> Am 01.09.19, 08:58 schrieb "P. Ottlinger" <po...@apache.org>:
>
> Am 28.08.19 um 03:00 schrieb Anatole Tresch:
> > [ ] +1 for community members who have reviewed the bits
>
> +1
>
> I played with the core artifacts and checked the homepage changes.
>
> Did not look into much detail into sandbox and extensions, but core
> looks fine.
>
> Cheers,
> Phil
>
>
>
--
*Anatole Tresch*
PPMC Member Apache Tamaya
JCP Star Spec Lead
*Switzerland, Europe Zurich, GMT+1*
*maketechsimple.wordpress.com <http://maketechsimple.wordpress.com/> *
*Twitter: @atsticks, @tamayaconf*