[GitHub] [pinot] mcvsubbu commented on a change in pull request #7984: PinotConfigProvider interface

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #7984:
URL: https://github.com/apache/pinot/pull/7984#discussion_r782481280



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/provider/PinotConfigProvider.java
##########
@@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.spi.config.provider;
+
+import org.apache.pinot.spi.config.table.TableConfig;
+import org.apache.pinot.spi.data.Schema;
+
+
+/**
+ * An interface for the provider of pinot table configs and schema
+ */
+public interface PinotConfigProvider {
+
+  /**
+   * Gets the tableConfig
+   */
+  TableConfig getTableConfig(String tableNameWithType);
+
+  /**
+   * Registers the {@link TableConfigChangeListener} and notifies it whenever any changes (addition, update, removal)
+   * to any of the table configs are detected
+   */
+  void registerTableConfigChangeListener(TableConfigChangeListener tableConfigChangeListener);

Review comment:
       Let us say a user of this interface wants to track the changes in table config. Looks like they need to get table config first and then register to listen to changes.
   
   Is there a race condition here? (changes may happen before they register, for instance).
   
   Does'nt it make sense to return the table config at the time of registration?
   
   Same with schema I suppose




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org