You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/14 21:43:36 UTC

[GitHub] [kafka] guozhangwang opened a new pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

guozhangwang opened a new pull request #9438:
URL: https://github.com/apache/kafka/pull/9438


   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9438:
URL: https://github.com/apache/kafka/pull/9438#issuecomment-709461497


   Updated the unit tests and merged to trunk.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #9438:
URL: https://github.com/apache/kafka/pull/9438


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9438:
URL: https://github.com/apache/kafka/pull/9438#issuecomment-708678537


   System tests on `StreamsUpgradeTest.test_metadata_upgrade`:
   
   trunk failed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4220/
   this branch succeeded: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4222/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9438:
URL: https://github.com/apache/kafka/pull/9438#issuecomment-708677767


   Can we add a test please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #9438: KAFKA-10613: Only set leader epoch when list-offset version >= 4

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #9438:
URL: https://github.com/apache/kafka/pull/9438#issuecomment-709462107


   Cherry-picking to 2.7 as well since it has a reasonably large impact for any old versioned clients. cc @bbejeck 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org