You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/12/02 02:42:48 UTC

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3838: feat: use fullName in jenkins

warren830 commented on code in PR #3838:
URL: https://github.com/apache/incubator-devlake/pull/3838#discussion_r1037737906


##########
plugins/jenkins/tasks/task_data.go:
##########
@@ -27,16 +28,15 @@ import (
 
 type JenkinsApiParams struct {
 	ConnectionId uint64
-	JobName      string
-	JobPath      string
+	FullName     string
 }
 
 type JenkinsOptions struct {
 	ConnectionId                      uint64 `json:"connectionId"`
 	TransformationRuleId              uint64 `json:"transformationRuleId"`
-	JobFullName                       string `json:"JobFullName"`
-	JobName                           string `json:"jobName"`
-	JobPath                           string `json:"jobPath"`
+	JobFullName                       string `json:"JobFullName"` // "path1/path2/job name"
+	JobName                           string `json:"jobName"`     // "job name"
+	JobPath                           string `json:"jobPath"`     // "job/path1/job/path2/job name"

Review Comment:
   job path should not contain job name:
   "job/path1/job/path2/job name" - > "job/path1/job/path2/"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org