You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/01/06 06:07:18 UTC
[GitHub] [iceberg] anuragmantri commented on a change in pull request #3851: API: Register existing tables in Iceberg HiveCatalog
anuragmantri commented on a change in pull request #3851:
URL: https://github.com/apache/iceberg/pull/3851#discussion_r779319373
##########
File path: hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java
##########
@@ -370,6 +371,85 @@ public void testNonDefaultDatabaseLocation() throws IOException, TException {
metastoreClient.dropDatabase(NON_DEFAULT_DATABASE, true, true, true);
}
+ @Test
+ public void testRegisterTable() throws TException {
+ org.apache.hadoop.hive.metastore.api.Table originalTable = metastoreClient.getTable(DB_NAME, TABLE_NAME);
+
+ Map<String, String> originalParams = originalTable.getParameters();
+ Assert.assertNotNull(originalParams);
+ Assert.assertTrue(ICEBERG_TABLE_TYPE_VALUE.equalsIgnoreCase(originalParams.get(TABLE_TYPE_PROP)));
+ Assert.assertTrue("EXTERNAL_TABLE".equalsIgnoreCase(originalTable.getTableType()));
+
+ catalog.dropTable(TABLE_IDENTIFIER, false);
+ Assert.assertFalse(catalog.tableExists(TABLE_IDENTIFIER));
+
+ List<String> metadataVersionFiles = metadataVersionFiles(TABLE_NAME);
+ Assert.assertEquals(1, metadataVersionFiles.size());
+
+ catalog.registerTable(TABLE_IDENTIFIER, "file:" + metadataVersionFiles.get(0));
+
+ org.apache.hadoop.hive.metastore.api.Table newTable = metastoreClient.getTable(DB_NAME, TABLE_NAME);
+
+ Map<String, String> newTableParameters = newTable.getParameters();
+ Assert.assertNull(newTableParameters.get(PREVIOUS_METADATA_LOCATION_PROP));
+ Assert.assertEquals(originalParams.get(TABLE_TYPE_PROP), newTableParameters.get(TABLE_TYPE_PROP));
+ Assert.assertEquals(originalParams.get(METADATA_LOCATION_PROP), newTableParameters.get(METADATA_LOCATION_PROP));
+ Assert.assertEquals(originalTable.getSd(), newTable.getSd());
+ }
+
+ @Test
+ public void testCloneTable() throws IOException {
Review comment:
Agreed :) Removed this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org