You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/28 14:13:27 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #903: test: add e2e test cases for route with trace plugin
nic-chen opened a new pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [x] E2E test
- Related issues
#636
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#issuecomment-735236138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=h1) Report
> Merging [#903](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=desc) (7e21b07) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/aec6d6cc7613cd7f2c583e99563e01e8a3391198?el=desc) (aec6d6c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 42.95% 42.95%
=======================================
Files 18 18
Lines 1271 1271
=======================================
Hits 546 546
Misses 633 633
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=footer). Last update [aec6d6c...7e21b07](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis merged pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#issuecomment-735236138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=h1) Report
> Merging [#903](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=desc) (684888a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4bb353d4be13990905024969103a530e8463c86c?el=desc) (4bb353d) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 43.03% 43.03%
=======================================
Files 18 18
Lines 1271 1271
=======================================
Hits 547 547
Misses 632 632
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=footer). Last update [4bb353d...684888a](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#issuecomment-735236138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=h1) Report
> Merging [#903](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=desc) (120fc40) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/aec6d6cc7613cd7f2c583e99563e01e8a3391198?el=desc) (aec6d6c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 42.95% 42.95%
=======================================
Files 18 18
Lines 1271 1271
=======================================
Hits 546 546
Misses 633 633
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=footer). Last update [aec6d6c...120fc40](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#issuecomment-735614483
@idbeta do you have time to take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on a change in pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#discussion_r532405660
##########
File path: api/test/e2e/route_with_trace_plugin_test.go
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "net/http"
+ "testing"
+ "time"
+
+ "github.com/stretchr/testify/assert"
+)
+
+func TestRoute_With_Plugin_Skywalking(t *testing.T) {
+ tests := []HttpTestCase{
+ {
+ caseDesc: "make sure the route is not created ",
+ Object: APISIXExpect(t),
Review comment:
This case is not good, it is not help to ensure the later cases execute normally.
If there is a dirty record in databases, all later cases will failed.
I think we can:
- remove this case
- Or change this case that make it can ensure there is no dirty record in database, such as `delete dirty record when it existed`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#issuecomment-735236138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=h1) Report
> Merging [#903](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=desc) (4b76089) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/aec6d6cc7613cd7f2c583e99563e01e8a3391198?el=desc) (aec6d6c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 42.95% 42.95%
=======================================
Files 18 18
Lines 1271 1271
=======================================
Hits 546 546
Misses 633 633
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=footer). Last update [aec6d6c...120fc40](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#discussion_r532355929
##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -41,3 +41,52 @@ apisix:
nginx_config:
error_log_level: "debug"
+
+plugins: # plugin list (sorted in alphabetical order)
+ - api-breaker
+ - authz-keycloak
+ - basic-auth
+ - batch-requests
+ - consumer-restriction
+ - cors
+ - echo
+ #- example-plugin
Review comment:
remove this line
##########
File path: api/test/e2e/route_with_trace_plugin_test.go
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "net/http"
+ "testing"
+ "time"
+
+ "github.com/stretchr/testify/assert"
+)
+
+func TestRoute_With_Plugin_Skywalking(t *testing.T) {
+ tests := []HttpTestCase{
+ {
+ caseDesc: "make sure the route is not created ",
+ Object: APISIXExpect(t),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not Found"}`,
+ },
+ {
+ caseDesc: "create route",
+ Object: MangerApiExpect(t),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: `{
+ "uri": "/hello",
+ "plugins": {
+ "skywalking": {
Review comment:
bad indentation
##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -41,3 +41,52 @@ apisix:
nginx_config:
error_log_level: "debug"
+
+plugins: # plugin list (sorted in alphabetical order)
+ - api-breaker
+ - authz-keycloak
+ - basic-auth
+ - batch-requests
+ - consumer-restriction
+ - cors
+ - echo
+ #- example-plugin
+ - fault-injection
+ - grpc-transcode
+ - hmac-auth
+ - http-logger
+ - ip-restriction
+ - jwt-auth
+ - kafka-logger
+ - key-auth
+ - limit-conn
+ - limit-count
+ - limit-req
+ #- log-rotate
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#discussion_r532382936
##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -41,3 +41,52 @@ apisix:
nginx_config:
error_log_level: "debug"
+
+plugins: # plugin list (sorted in alphabetical order)
+ - api-breaker
+ - authz-keycloak
+ - basic-auth
+ - batch-requests
+ - consumer-restriction
+ - cors
+ - echo
+ #- example-plugin
Review comment:
fixed.
##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -41,3 +41,52 @@ apisix:
nginx_config:
error_log_level: "debug"
+
+plugins: # plugin list (sorted in alphabetical order)
+ - api-breaker
+ - authz-keycloak
+ - basic-auth
+ - batch-requests
+ - consumer-restriction
+ - cors
+ - echo
+ #- example-plugin
+ - fault-injection
+ - grpc-transcode
+ - hmac-auth
+ - http-logger
+ - ip-restriction
+ - jwt-auth
+ - kafka-logger
+ - key-auth
+ - limit-conn
+ - limit-count
+ - limit-req
+ #- log-rotate
Review comment:
fixed.
##########
File path: api/test/e2e/route_with_trace_plugin_test.go
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "net/http"
+ "testing"
+ "time"
+
+ "github.com/stretchr/testify/assert"
+)
+
+func TestRoute_With_Plugin_Skywalking(t *testing.T) {
+ tests := []HttpTestCase{
+ {
+ caseDesc: "make sure the route is not created ",
+ Object: APISIXExpect(t),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not Found"}`,
+ },
+ {
+ caseDesc: "create route",
+ Object: MangerApiExpect(t),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: `{
+ "uri": "/hello",
+ "plugins": {
+ "skywalking": {
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#issuecomment-735628788
> @idbeta do you have time to take a look at this PR?
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#issuecomment-735236138
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=h1) Report
> Merging [#903](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=desc) (8569c05) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/4bb353d4be13990905024969103a530e8463c86c?el=desc) (4bb353d) will **decrease** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
- Coverage 43.03% 42.95% -0.08%
==========================================
Files 18 18
Lines 1271 1271
==========================================
- Hits 547 546 -1
- Misses 632 633 +1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/903/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.28% <0.00%> (-0.66%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=footer). Last update [4bb353d...8569c05](https://codecov.io/gh/apache/apisix-dashboard/pull/903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #903: test: add e2e test cases for route with trace plugin
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #903:
URL: https://github.com/apache/apisix-dashboard/pull/903#discussion_r532409618
##########
File path: api/test/e2e/route_with_trace_plugin_test.go
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "net/http"
+ "testing"
+ "time"
+
+ "github.com/stretchr/testify/assert"
+)
+
+func TestRoute_With_Plugin_Skywalking(t *testing.T) {
+ tests := []HttpTestCase{
+ {
+ caseDesc: "make sure the route is not created ",
+ Object: APISIXExpect(t),
Review comment:
thanks for the review.
what we need to ensure is that the test cases of the current file is not interfered by other.
if it fail, just let it fail, and fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org