You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/24 06:57:24 UTC

[GitHub] [pulsar] nodece opened a new pull request, #17253: [fix][ci] Fix docbot always cancelled

nodece opened a new pull request, #17253:
URL: https://github.com/apache/pulsar/pull/17253

   Signed-off-by: Zixuan Liu <no...@gmail.com>
   
   ### Motivation
   
   Randome pick a PR, you will see the docbot CI is always cancelled.
   
   Root cause is using `${{ github.workflow }}-${{ github.ref }}` as id to cancel the docbot task.
   
   The `github.ref` value is always what the PR wants to submit to the base branch like:
   ```
   Canceling since a higher priority waiting request for 'Documentation Bot-refs/heads/master' exists
   ```
   
   So you saw always cancelled, right now using the workflow name and the PR number instead.
   
   ### Modifications
   
   - Fix `concurrency.group` value, using `github.pull_request.number` instead of `github.ref`, 
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #17253: [fix][ci] Fix docbot always cancelled

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17253:
URL: https://github.com/apache/pulsar/pull/17253#issuecomment-1225770537

   I think we can give it a try. cc @codelipenghui @lhotari 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #17253: [fix][ci] Fix docbot always cancelled

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17253:
URL: https://github.com/apache/pulsar/pull/17253#issuecomment-1225312178

   /cc @maxsxu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] maxsxu commented on a diff in pull request #17253: [fix][ci] Fix docbot always cancelled

Posted by GitBox <gi...@apache.org>.
maxsxu commented on code in PR #17253:
URL: https://github.com/apache/pulsar/pull/17253#discussion_r953559386


##########
.github/workflows/ci-documentbot.yml:
##########
@@ -28,7 +28,7 @@ on:
       - unlabeled
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.pull_request.number }}

Review Comment:
   Should use `${{ github.workflow }}-${{ github.ref }}-${{ github.event.pull_request.number }}` as the concurrency group can only use the [github context](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency)
   
   The `github.pull_request.number` can only be retrieved within job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #17253: [fix][ci] Fix docbot always cancelled

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17253:
URL: https://github.com/apache/pulsar/pull/17253#issuecomment-1225294313

   @nodece I think it's because we use [`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) event trigger here so the logic will only take effect once merged.
   
   Although, I'm not quite familiar with this domain so it can be wrong. Instead of replacing `github.ref` with `github. pull_request.number`, I suggest you use `${{ github.workflow }}-${{ github.ref }}-${{ github. pull_request.number }}` to see whether it helps after merge, while prevents any regression.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on pull request #17253: [fix][ci] Fix docbot always cancelled

Posted by GitBox <gi...@apache.org>.
nodece commented on PR #17253:
URL: https://github.com/apache/pulsar/pull/17253#issuecomment-1225291476

   Hi @tisonkun, this issue still exists, see https://github.com/apache/pulsar/runs/7989085768?check_suite_focus=true, looks like CI is not using the latest configuration?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece merged pull request #17253: [fix][ci] Fix docbot always cancelled

Posted by GitBox <gi...@apache.org>.
nodece merged PR #17253:
URL: https://github.com/apache/pulsar/pull/17253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] nodece commented on a diff in pull request #17253: [fix][ci] Fix docbot always cancelled

Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #17253:
URL: https://github.com/apache/pulsar/pull/17253#discussion_r953840022


##########
.github/workflows/ci-documentbot.yml:
##########
@@ -28,7 +28,7 @@ on:
       - unlabeled
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.pull_request.number }}

Review Comment:
   Thank @maxsxu, I updated this value, using the `github.event.number` instead of the `github.pull_request.number`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org