You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 07:48:33 UTC
[GitHub] [airflow] potiuk opened a new pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
potiuk opened a new pull request #11876:
URL: https://github.com/apache/airflow/pull/11876
GitHub Actions policy about runnig scheduled workflows in forks
has changed recently and as of October 27 2020 scheduled workflows
in forks will be disabled. Thanks to that change we can simplify
some of our conditions that disallowed running scheduled workflows
in forks.
The change is active as of today (email from GitHub):
> What will happen to scheduled workflows in forks I already have?
> If you already have scheduled workflows in forks of public
repositories, they will be disabled on October 27, 2020. Repository
owners will receive a reminder email 7 days prior and can choose to
keep the workflows running at that time if they are needed.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11876:
URL: https://github.com/apache/airflow/pull/11876#issuecomment-717920713
> Is there a public link where I can find this news?
I searched for it but could not find it. They never explicitly said how the scheduled workflows run in forks so likely they change it a bit "silently" :(. I can forward you the email (you probably got it as well )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11876:
URL: https://github.com/apache/airflow/pull/11876#issuecomment-717927977
> > > I haven't actually or may I didn't subscribe to their newsletter , if you can forward it please :)
> >
> >
> > I will forward it to the devlist and warn our users as well.
>
> sent
Thanks 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11876:
URL: https://github.com/apache/airflow/pull/11876#issuecomment-717924350
> > Is there a public link where I can find this news?
>
> I searched for it but could not find it. They never explicitly said how the scheduled workflows run in forks so likely they change it a bit "silently" :(. I can forward you the email (you probably got it as well )
I haven't actually or may I didn't subscribe to their newsletter , if you can forward it please :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11876:
URL: https://github.com/apache/airflow/pull/11876#discussion_r513428087
##########
File path: .github/workflows/delete_old_artifacts.yml
##########
@@ -7,7 +7,6 @@ on: # yamllint disable-line rule:truthy
jobs:
delete-artifacts:
runs-on: ubuntu-latest
- if: github.repository == 'apache/airflow'
Review comment:
Nope. This is a scheduled run so it will not run in forks as of yesterday unless someone explicitly wants it. Which should be OK if someone wants to follow the same cleaning as Airflow does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11876:
URL: https://github.com/apache/airflow/pull/11876#issuecomment-717926840
> > I haven't actually or may I didn't subscribe to their newsletter , if you can forward it please :)
>
> I will forward it to the devlist and warn our users as well.
sent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11876:
URL: https://github.com/apache/airflow/pull/11876#discussion_r513405287
##########
File path: .github/workflows/delete_old_artifacts.yml
##########
@@ -7,7 +7,6 @@ on: # yamllint disable-line rule:truthy
jobs:
delete-artifacts:
runs-on: ubuntu-latest
- if: github.repository == 'apache/airflow'
Review comment:
We still want this, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11876:
URL: https://github.com/apache/airflow/pull/11876
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11876: Simplify "scheduled" conditons to follow today's change in GA
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11876:
URL: https://github.com/apache/airflow/pull/11876#issuecomment-717926179
> I haven't actually or may I didn't subscribe to their newsletter , if you can forward it please :)
I will forward it to the devlist and warn our users as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org