[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #9394: [IOTDB-5704] Change default parameters for wal part

["OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>]

OneSizeFitsQuorum commented on code in PR #9394:
URL: https://github.com/apache/iotdb/pull/9394#discussion_r1142889672


##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -663,22 +663,22 @@ cluster_name=defaultCluster
 # A duration greater than 0 batches multiple wal fsync calls into one. This is useful when disks are slow or WAL write contention exists.
 # Notice: this value affects write performance significantly, values in the range of 0ms-10ms are recommended.

Review Comment:
   Change these comments?



##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -663,22 +663,22 @@ cluster_name=defaultCluster
 # A duration greater than 0 batches multiple wal fsync calls into one. This is useful when disks are slow or WAL write contention exists.
 # Notice: this value affects write performance significantly, values in the range of 0ms-10ms are recommended.
 # Datatype: long
-# fsync_wal_delay_in_ms=3
+# fsync_wal_delay_in_ms=1000
 
 # Buffer size of each wal node
 # If it's a value smaller than 0, use the default value 16 * 1024 * 1024 bytes (16MB).
 # Datatype: int
-# wal_buffer_size_in_byte=16777216
+# wal_buffer_size_in_byte=33554432
 
 # Blocking queue capacity of each wal buffer, restricts maximum number of WALEdits cached in the blocking queue.
 # Datatype: int
-# wal_buffer_queue_capacity=50
+# wal_buffer_queue_capacity=500
 
 # Size threshold of each wal file
 # When a wal file's size exceeds this, the wal file will be closed and a new wal file will be created.
 # If it's a value smaller than 0, use the default value 10 * 1024 * 1024 (10MB).

Review Comment:
   Change these comments?



##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -663,22 +663,22 @@ cluster_name=defaultCluster
 # A duration greater than 0 batches multiple wal fsync calls into one. This is useful when disks are slow or WAL write contention exists.
 # Notice: this value affects write performance significantly, values in the range of 0ms-10ms are recommended.
 # Datatype: long
-# fsync_wal_delay_in_ms=3
+# fsync_wal_delay_in_ms=1000
 
 # Buffer size of each wal node
 # If it's a value smaller than 0, use the default value 16 * 1024 * 1024 bytes (16MB).

Review Comment:
   Change these comments?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org