You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/01 22:26:00 UTC
[GitHub] [arrow] zeroshade opened a new pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
zeroshade opened a new pull request #9392:
URL: https://github.com/apache/arrow/pull/9392
Adding support for more header based authentication in Flight server and clients.
- Base64 encoded username/password auth
- Bearertoken receiving and population of context metadata
- Unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9392:
URL: https://github.com/apache/arrow/pull/9392#issuecomment-771203293
https://issues.apache.org/jira/browse/ARROW-11466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] WilliamWhispell commented on a change in pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
Posted by GitBox <gi...@apache.org>.
WilliamWhispell commented on a change in pull request #9392:
URL: https://github.com/apache/arrow/pull/9392#discussion_r568209580
##########
File path: go/arrow/flight/client.go
##########
@@ -33,6 +38,7 @@ type Client interface {
// Authenticate uses the ClientAuthHandler that was used when creating the client
// in order to use the Handshake endpoints of the service.
Authenticate(context.Context, ...grpc.CallOption) error
+ AuthenticateBasicToken(context.Context, string, string, ...grpc.CallOption) (context.Context, error)
Review comment:
I know its obvious, but having var names might make it quicker to verify second and third params are for user and serial
##########
File path: go/arrow/flight/client.go
##########
@@ -33,6 +38,7 @@ type Client interface {
// Authenticate uses the ClientAuthHandler that was used when creating the client
// in order to use the Handshake endpoints of the service.
Authenticate(context.Context, ...grpc.CallOption) error
+ AuthenticateBasicToken(context.Context, string, string, ...grpc.CallOption) (context.Context, error)
Review comment:
I know its obvious, but having var names might make it quicker to verify second and third params are for user and pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sbinet closed pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
Posted by GitBox <gi...@apache.org>.
sbinet closed pull request #9392:
URL: https://github.com/apache/arrow/pull/9392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] WilliamWhispell commented on a change in pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
Posted by GitBox <gi...@apache.org>.
WilliamWhispell commented on a change in pull request #9392:
URL: https://github.com/apache/arrow/pull/9392#discussion_r568209580
##########
File path: go/arrow/flight/client.go
##########
@@ -33,6 +38,7 @@ type Client interface {
// Authenticate uses the ClientAuthHandler that was used when creating the client
// in order to use the Handshake endpoints of the service.
Authenticate(context.Context, ...grpc.CallOption) error
+ AuthenticateBasicToken(context.Context, string, string, ...grpc.CallOption) (context.Context, error)
Review comment:
I know its obvious, but having var names might make it quicker to verify second and third params are for user and pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] WilliamWhispell commented on a change in pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
Posted by GitBox <gi...@apache.org>.
WilliamWhispell commented on a change in pull request #9392:
URL: https://github.com/apache/arrow/pull/9392#discussion_r568209580
##########
File path: go/arrow/flight/client.go
##########
@@ -33,6 +38,7 @@ type Client interface {
// Authenticate uses the ClientAuthHandler that was used when creating the client
// in order to use the Handshake endpoints of the service.
Authenticate(context.Context, ...grpc.CallOption) error
+ AuthenticateBasicToken(context.Context, string, string, ...grpc.CallOption) (context.Context, error)
Review comment:
I know its obvious, but having var names might make it quicker to verify second and third params are for user and serial
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sbinet closed pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
Posted by GitBox <gi...@apache.org>.
sbinet closed pull request #9392:
URL: https://github.com/apache/arrow/pull/9392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #9392: ARROW-11466: [Go][Flight] adding Basic Auth handling for go flight client and server
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #9392:
URL: https://github.com/apache/arrow/pull/9392#issuecomment-772745661
I'm just gonna tag the ppl i've interacted with before / have gotten merged by before in order to get some attention on this.
@wesm @xhochy @sbinet
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org