You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/04/11 14:48:27 UTC
[04/16] hbase-site git commit: Published site at
37e5b0b1b790fef25a544c282c6556e009269a0e.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/c8fd155e/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.html
index 4396e76..c0d719f 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.html
@@ -27,324 +27,342 @@
<span class="sourceLineNo">019</span>package org.apache.hadoop.hbase.master.procedure;<a name="line.19"></a>
<span class="sourceLineNo">020</span><a name="line.20"></a>
<span class="sourceLineNo">021</span>import java.io.IOException;<a name="line.21"></a>
-<span class="sourceLineNo">022</span><a name="line.22"></a>
-<span class="sourceLineNo">023</span>import org.apache.hadoop.hbase.HBaseIOException;<a name="line.23"></a>
-<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.24"></a>
-<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.TableName;<a name="line.25"></a>
-<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.TableNotEnabledException;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.TableNotFoundException;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.slf4j.Logger;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import org.slf4j.LoggerFactory;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.client.TableState;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.constraint.ConstraintException;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.master.TableStateManager;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.DisableTableState;<a name="line.38"></a>
-<span class="sourceLineNo">039</span><a name="line.39"></a>
-<span class="sourceLineNo">040</span>@InterfaceAudience.Private<a name="line.40"></a>
-<span class="sourceLineNo">041</span>public class DisableTableProcedure<a name="line.41"></a>
-<span class="sourceLineNo">042</span> extends AbstractStateMachineTableProcedure<DisableTableState> {<a name="line.42"></a>
-<span class="sourceLineNo">043</span> private static final Logger LOG = LoggerFactory.getLogger(DisableTableProcedure.class);<a name="line.43"></a>
+<span class="sourceLineNo">022</span>import org.apache.hadoop.hbase.HBaseIOException;<a name="line.22"></a>
+<span class="sourceLineNo">023</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.TableName;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.TableNotEnabledException;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.TableNotFoundException;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.client.BufferedMutator;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.client.TableState;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.constraint.ConstraintException;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.master.MasterFileSystem;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.master.TableStateManager;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.wal.WALSplitter;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.slf4j.Logger;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.slf4j.LoggerFactory;<a name="line.39"></a>
+<span class="sourceLineNo">040</span><a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.DisableTableState;<a name="line.43"></a>
<span class="sourceLineNo">044</span><a name="line.44"></a>
-<span class="sourceLineNo">045</span> private TableName tableName;<a name="line.45"></a>
-<span class="sourceLineNo">046</span> private boolean skipTableStateCheck;<a name="line.46"></a>
-<span class="sourceLineNo">047</span><a name="line.47"></a>
-<span class="sourceLineNo">048</span> private Boolean traceEnabled = null;<a name="line.48"></a>
+<span class="sourceLineNo">045</span>@InterfaceAudience.Private<a name="line.45"></a>
+<span class="sourceLineNo">046</span>public class DisableTableProcedure<a name="line.46"></a>
+<span class="sourceLineNo">047</span> extends AbstractStateMachineTableProcedure<DisableTableState> {<a name="line.47"></a>
+<span class="sourceLineNo">048</span> private static final Logger LOG = LoggerFactory.getLogger(DisableTableProcedure.class);<a name="line.48"></a>
<span class="sourceLineNo">049</span><a name="line.49"></a>
-<span class="sourceLineNo">050</span> public DisableTableProcedure() {<a name="line.50"></a>
-<span class="sourceLineNo">051</span> super();<a name="line.51"></a>
-<span class="sourceLineNo">052</span> }<a name="line.52"></a>
-<span class="sourceLineNo">053</span><a name="line.53"></a>
-<span class="sourceLineNo">054</span> /**<a name="line.54"></a>
-<span class="sourceLineNo">055</span> * Constructor<a name="line.55"></a>
-<span class="sourceLineNo">056</span> * @param env MasterProcedureEnv<a name="line.56"></a>
-<span class="sourceLineNo">057</span> * @param tableName the table to operate on<a name="line.57"></a>
-<span class="sourceLineNo">058</span> * @param skipTableStateCheck whether to check table state<a name="line.58"></a>
-<span class="sourceLineNo">059</span> */<a name="line.59"></a>
-<span class="sourceLineNo">060</span> public DisableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.60"></a>
-<span class="sourceLineNo">061</span> final boolean skipTableStateCheck)<a name="line.61"></a>
-<span class="sourceLineNo">062</span> throws HBaseIOException {<a name="line.62"></a>
-<span class="sourceLineNo">063</span> this(env, tableName, skipTableStateCheck, null);<a name="line.63"></a>
-<span class="sourceLineNo">064</span> }<a name="line.64"></a>
-<span class="sourceLineNo">065</span><a name="line.65"></a>
-<span class="sourceLineNo">066</span> /**<a name="line.66"></a>
-<span class="sourceLineNo">067</span> * Constructor<a name="line.67"></a>
-<span class="sourceLineNo">068</span> * @param env MasterProcedureEnv<a name="line.68"></a>
-<span class="sourceLineNo">069</span> * @param tableName the table to operate on<a name="line.69"></a>
-<span class="sourceLineNo">070</span> * @param skipTableStateCheck whether to check table state<a name="line.70"></a>
-<span class="sourceLineNo">071</span> */<a name="line.71"></a>
-<span class="sourceLineNo">072</span> public DisableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.72"></a>
-<span class="sourceLineNo">073</span> final boolean skipTableStateCheck, final ProcedurePrepareLatch syncLatch)<a name="line.73"></a>
-<span class="sourceLineNo">074</span> throws HBaseIOException {<a name="line.74"></a>
-<span class="sourceLineNo">075</span> super(env, syncLatch);<a name="line.75"></a>
-<span class="sourceLineNo">076</span> this.tableName = tableName;<a name="line.76"></a>
-<span class="sourceLineNo">077</span> preflightChecks(env, true);<a name="line.77"></a>
-<span class="sourceLineNo">078</span> this.skipTableStateCheck = skipTableStateCheck;<a name="line.78"></a>
-<span class="sourceLineNo">079</span> }<a name="line.79"></a>
-<span class="sourceLineNo">080</span><a name="line.80"></a>
-<span class="sourceLineNo">081</span> @Override<a name="line.81"></a>
-<span class="sourceLineNo">082</span> protected Flow executeFromState(final MasterProcedureEnv env, final DisableTableState state)<a name="line.82"></a>
-<span class="sourceLineNo">083</span> throws InterruptedException {<a name="line.83"></a>
-<span class="sourceLineNo">084</span> if (isTraceEnabled()) {<a name="line.84"></a>
-<span class="sourceLineNo">085</span> LOG.trace(this + " execute state=" + state);<a name="line.85"></a>
-<span class="sourceLineNo">086</span> }<a name="line.86"></a>
-<span class="sourceLineNo">087</span><a name="line.87"></a>
-<span class="sourceLineNo">088</span> try {<a name="line.88"></a>
-<span class="sourceLineNo">089</span> switch (state) {<a name="line.89"></a>
-<span class="sourceLineNo">090</span> case DISABLE_TABLE_PREPARE:<a name="line.90"></a>
-<span class="sourceLineNo">091</span> if (prepareDisable(env)) {<a name="line.91"></a>
-<span class="sourceLineNo">092</span> setNextState(DisableTableState.DISABLE_TABLE_PRE_OPERATION);<a name="line.92"></a>
-<span class="sourceLineNo">093</span> } else {<a name="line.93"></a>
-<span class="sourceLineNo">094</span> assert isFailed() : "disable should have an exception here";<a name="line.94"></a>
-<span class="sourceLineNo">095</span> return Flow.NO_MORE_STATE;<a name="line.95"></a>
-<span class="sourceLineNo">096</span> }<a name="line.96"></a>
-<span class="sourceLineNo">097</span> break;<a name="line.97"></a>
-<span class="sourceLineNo">098</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.98"></a>
-<span class="sourceLineNo">099</span> preDisable(env, state);<a name="line.99"></a>
-<span class="sourceLineNo">100</span> setNextState(DisableTableState.DISABLE_TABLE_SET_DISABLING_TABLE_STATE);<a name="line.100"></a>
-<span class="sourceLineNo">101</span> break;<a name="line.101"></a>
-<span class="sourceLineNo">102</span> case DISABLE_TABLE_SET_DISABLING_TABLE_STATE:<a name="line.102"></a>
-<span class="sourceLineNo">103</span> setTableStateToDisabling(env, tableName);<a name="line.103"></a>
-<span class="sourceLineNo">104</span> setNextState(DisableTableState.DISABLE_TABLE_MARK_REGIONS_OFFLINE);<a name="line.104"></a>
-<span class="sourceLineNo">105</span> break;<a name="line.105"></a>
-<span class="sourceLineNo">106</span> case DISABLE_TABLE_MARK_REGIONS_OFFLINE:<a name="line.106"></a>
-<span class="sourceLineNo">107</span> addChildProcedure(env.getAssignmentManager().createUnassignProcedures(tableName));<a name="line.107"></a>
-<span class="sourceLineNo">108</span> setNextState(DisableTableState.DISABLE_TABLE_SET_DISABLED_TABLE_STATE);<a name="line.108"></a>
-<span class="sourceLineNo">109</span> break;<a name="line.109"></a>
-<span class="sourceLineNo">110</span> case DISABLE_TABLE_SET_DISABLED_TABLE_STATE:<a name="line.110"></a>
-<span class="sourceLineNo">111</span> setTableStateToDisabled(env, tableName);<a name="line.111"></a>
-<span class="sourceLineNo">112</span> setNextState(DisableTableState.DISABLE_TABLE_POST_OPERATION);<a name="line.112"></a>
-<span class="sourceLineNo">113</span> break;<a name="line.113"></a>
-<span class="sourceLineNo">114</span> case DISABLE_TABLE_POST_OPERATION:<a name="line.114"></a>
-<span class="sourceLineNo">115</span> postDisable(env, state);<a name="line.115"></a>
-<span class="sourceLineNo">116</span> return Flow.NO_MORE_STATE;<a name="line.116"></a>
-<span class="sourceLineNo">117</span> default:<a name="line.117"></a>
-<span class="sourceLineNo">118</span> throw new UnsupportedOperationException("Unhandled state=" + state);<a name="line.118"></a>
-<span class="sourceLineNo">119</span> }<a name="line.119"></a>
-<span class="sourceLineNo">120</span> } catch (IOException e) {<a name="line.120"></a>
-<span class="sourceLineNo">121</span> if (isRollbackSupported(state)) {<a name="line.121"></a>
-<span class="sourceLineNo">122</span> setFailure("master-disable-table", e);<a name="line.122"></a>
-<span class="sourceLineNo">123</span> } else {<a name="line.123"></a>
-<span class="sourceLineNo">124</span> LOG.warn("Retriable error trying to disable table=" + tableName +<a name="line.124"></a>
-<span class="sourceLineNo">125</span> " (in state=" + state + ")", e);<a name="line.125"></a>
-<span class="sourceLineNo">126</span> }<a name="line.126"></a>
-<span class="sourceLineNo">127</span> }<a name="line.127"></a>
-<span class="sourceLineNo">128</span> return Flow.HAS_MORE_STATE;<a name="line.128"></a>
-<span class="sourceLineNo">129</span> }<a name="line.129"></a>
-<span class="sourceLineNo">130</span><a name="line.130"></a>
-<span class="sourceLineNo">131</span> @Override<a name="line.131"></a>
-<span class="sourceLineNo">132</span> protected void rollbackState(final MasterProcedureEnv env, final DisableTableState state)<a name="line.132"></a>
-<span class="sourceLineNo">133</span> throws IOException {<a name="line.133"></a>
-<span class="sourceLineNo">134</span> // nothing to rollback, prepare-disable is just table-state checks.<a name="line.134"></a>
-<span class="sourceLineNo">135</span> // We can fail if the table does not exist or is not disabled.<a name="line.135"></a>
-<span class="sourceLineNo">136</span> switch (state) {<a name="line.136"></a>
-<span class="sourceLineNo">137</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.137"></a>
-<span class="sourceLineNo">138</span> return;<a name="line.138"></a>
-<span class="sourceLineNo">139</span> case DISABLE_TABLE_PREPARE:<a name="line.139"></a>
-<span class="sourceLineNo">140</span> releaseSyncLatch();<a name="line.140"></a>
-<span class="sourceLineNo">141</span> return;<a name="line.141"></a>
-<span class="sourceLineNo">142</span> default:<a name="line.142"></a>
-<span class="sourceLineNo">143</span> break;<a name="line.143"></a>
-<span class="sourceLineNo">144</span> }<a name="line.144"></a>
-<span class="sourceLineNo">145</span><a name="line.145"></a>
-<span class="sourceLineNo">146</span> // The delete doesn't have a rollback. The execution will succeed, at some point.<a name="line.146"></a>
-<span class="sourceLineNo">147</span> throw new UnsupportedOperationException("Unhandled state=" + state);<a name="line.147"></a>
-<span class="sourceLineNo">148</span> }<a name="line.148"></a>
-<span class="sourceLineNo">149</span><a name="line.149"></a>
-<span class="sourceLineNo">150</span> @Override<a name="line.150"></a>
-<span class="sourceLineNo">151</span> protected boolean isRollbackSupported(final DisableTableState state) {<a name="line.151"></a>
-<span class="sourceLineNo">152</span> switch (state) {<a name="line.152"></a>
-<span class="sourceLineNo">153</span> case DISABLE_TABLE_PREPARE:<a name="line.153"></a>
-<span class="sourceLineNo">154</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.154"></a>
-<span class="sourceLineNo">155</span> return true;<a name="line.155"></a>
-<span class="sourceLineNo">156</span> default:<a name="line.156"></a>
-<span class="sourceLineNo">157</span> return false;<a name="line.157"></a>
-<span class="sourceLineNo">158</span> }<a name="line.158"></a>
-<span class="sourceLineNo">159</span> }<a name="line.159"></a>
-<span class="sourceLineNo">160</span><a name="line.160"></a>
-<span class="sourceLineNo">161</span> @Override<a name="line.161"></a>
-<span class="sourceLineNo">162</span> protected DisableTableState getState(final int stateId) {<a name="line.162"></a>
-<span class="sourceLineNo">163</span> return DisableTableState.valueOf(stateId);<a name="line.163"></a>
-<span class="sourceLineNo">164</span> }<a name="line.164"></a>
-<span class="sourceLineNo">165</span><a name="line.165"></a>
-<span class="sourceLineNo">166</span> @Override<a name="line.166"></a>
-<span class="sourceLineNo">167</span> protected int getStateId(final DisableTableState state) {<a name="line.167"></a>
-<span class="sourceLineNo">168</span> return state.getNumber();<a name="line.168"></a>
-<span class="sourceLineNo">169</span> }<a name="line.169"></a>
-<span class="sourceLineNo">170</span><a name="line.170"></a>
-<span class="sourceLineNo">171</span> @Override<a name="line.171"></a>
-<span class="sourceLineNo">172</span> protected DisableTableState getInitialState() {<a name="line.172"></a>
-<span class="sourceLineNo">173</span> return DisableTableState.DISABLE_TABLE_PREPARE;<a name="line.173"></a>
-<span class="sourceLineNo">174</span> }<a name="line.174"></a>
-<span class="sourceLineNo">175</span><a name="line.175"></a>
-<span class="sourceLineNo">176</span> @Override<a name="line.176"></a>
-<span class="sourceLineNo">177</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.177"></a>
-<span class="sourceLineNo">178</span> throws IOException {<a name="line.178"></a>
-<span class="sourceLineNo">179</span> super.serializeStateData(serializer);<a name="line.179"></a>
-<span class="sourceLineNo">180</span><a name="line.180"></a>
-<span class="sourceLineNo">181</span> MasterProcedureProtos.DisableTableStateData.Builder disableTableMsg =<a name="line.181"></a>
-<span class="sourceLineNo">182</span> MasterProcedureProtos.DisableTableStateData.newBuilder()<a name="line.182"></a>
-<span class="sourceLineNo">183</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.183"></a>
-<span class="sourceLineNo">184</span> .setTableName(ProtobufUtil.toProtoTableName(tableName))<a name="line.184"></a>
-<span class="sourceLineNo">185</span> .setSkipTableStateCheck(skipTableStateCheck);<a name="line.185"></a>
-<span class="sourceLineNo">186</span><a name="line.186"></a>
-<span class="sourceLineNo">187</span> serializer.serialize(disableTableMsg.build());<a name="line.187"></a>
-<span class="sourceLineNo">188</span> }<a name="line.188"></a>
-<span class="sourceLineNo">189</span><a name="line.189"></a>
-<span class="sourceLineNo">190</span> @Override<a name="line.190"></a>
-<span class="sourceLineNo">191</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.191"></a>
-<span class="sourceLineNo">192</span> throws IOException {<a name="line.192"></a>
-<span class="sourceLineNo">193</span> super.deserializeStateData(serializer);<a name="line.193"></a>
-<span class="sourceLineNo">194</span><a name="line.194"></a>
-<span class="sourceLineNo">195</span> MasterProcedureProtos.DisableTableStateData disableTableMsg =<a name="line.195"></a>
-<span class="sourceLineNo">196</span> serializer.deserialize(MasterProcedureProtos.DisableTableStateData.class);<a name="line.196"></a>
-<span class="sourceLineNo">197</span> setUser(MasterProcedureUtil.toUserInfo(disableTableMsg.getUserInfo()));<a name="line.197"></a>
-<span class="sourceLineNo">198</span> tableName = ProtobufUtil.toTableName(disableTableMsg.getTableName());<a name="line.198"></a>
-<span class="sourceLineNo">199</span> skipTableStateCheck = disableTableMsg.getSkipTableStateCheck();<a name="line.199"></a>
-<span class="sourceLineNo">200</span> }<a name="line.200"></a>
-<span class="sourceLineNo">201</span><a name="line.201"></a>
-<span class="sourceLineNo">202</span> @Override<a name="line.202"></a>
-<span class="sourceLineNo">203</span> public TableName getTableName() {<a name="line.203"></a>
-<span class="sourceLineNo">204</span> return tableName;<a name="line.204"></a>
-<span class="sourceLineNo">205</span> }<a name="line.205"></a>
-<span class="sourceLineNo">206</span><a name="line.206"></a>
-<span class="sourceLineNo">207</span> @Override<a name="line.207"></a>
-<span class="sourceLineNo">208</span> public TableOperationType getTableOperationType() {<a name="line.208"></a>
-<span class="sourceLineNo">209</span> return TableOperationType.DISABLE;<a name="line.209"></a>
-<span class="sourceLineNo">210</span> }<a name="line.210"></a>
-<span class="sourceLineNo">211</span><a name="line.211"></a>
-<span class="sourceLineNo">212</span> /**<a name="line.212"></a>
-<span class="sourceLineNo">213</span> * Action before any real action of disabling table. Set the exception in the procedure instead<a name="line.213"></a>
-<span class="sourceLineNo">214</span> * of throwing it. This approach is to deal with backward compatible with 1.0.<a name="line.214"></a>
-<span class="sourceLineNo">215</span> * @param env MasterProcedureEnv<a name="line.215"></a>
-<span class="sourceLineNo">216</span> * @throws IOException<a name="line.216"></a>
-<span class="sourceLineNo">217</span> */<a name="line.217"></a>
-<span class="sourceLineNo">218</span> private boolean prepareDisable(final MasterProcedureEnv env) throws IOException {<a name="line.218"></a>
-<span class="sourceLineNo">219</span> boolean canTableBeDisabled = true;<a name="line.219"></a>
-<span class="sourceLineNo">220</span> if (tableName.equals(TableName.META_TABLE_NAME)) {<a name="line.220"></a>
-<span class="sourceLineNo">221</span> setFailure("master-disable-table", new ConstraintException("Cannot disable catalog table"));<a name="line.221"></a>
-<span class="sourceLineNo">222</span> canTableBeDisabled = false;<a name="line.222"></a>
-<span class="sourceLineNo">223</span> } else if (!MetaTableAccessor.tableExists(env.getMasterServices().getConnection(), tableName)) {<a name="line.223"></a>
-<span class="sourceLineNo">224</span> setFailure("master-disable-table", new TableNotFoundException(tableName));<a name="line.224"></a>
-<span class="sourceLineNo">225</span> canTableBeDisabled = false;<a name="line.225"></a>
-<span class="sourceLineNo">226</span> } else if (!skipTableStateCheck) {<a name="line.226"></a>
-<span class="sourceLineNo">227</span> // There could be multiple client requests trying to disable or enable<a name="line.227"></a>
-<span class="sourceLineNo">228</span> // the table at the same time. Ensure only the first request is honored<a name="line.228"></a>
-<span class="sourceLineNo">229</span> // After that, no other requests can be accepted until the table reaches<a name="line.229"></a>
-<span class="sourceLineNo">230</span> // DISABLED or ENABLED.<a name="line.230"></a>
-<span class="sourceLineNo">231</span> //<a name="line.231"></a>
-<span class="sourceLineNo">232</span> // Note: in 1.0 release, we called TableStateManager.setTableStateIfInStates() to set<a name="line.232"></a>
-<span class="sourceLineNo">233</span> // the state to DISABLING from ENABLED. The implementation was done before table lock<a name="line.233"></a>
-<span class="sourceLineNo">234</span> // was implemented. With table lock, there is no need to set the state here (it will<a name="line.234"></a>
-<span class="sourceLineNo">235</span> // set the state later on). A quick state check should be enough for us to move forward.<a name="line.235"></a>
-<span class="sourceLineNo">236</span> TableStateManager tsm = env.getMasterServices().getTableStateManager();<a name="line.236"></a>
-<span class="sourceLineNo">237</span> TableState ts = tsm.getTableState(tableName);<a name="line.237"></a>
-<span class="sourceLineNo">238</span> if (!ts.isEnabled()) {<a name="line.238"></a>
-<span class="sourceLineNo">239</span> LOG.info("Not ENABLED tableState=" + ts + "; skipping disable");<a name="line.239"></a>
-<span class="sourceLineNo">240</span> setFailure("master-disable-table", new TableNotEnabledException(ts.toString()));<a name="line.240"></a>
-<span class="sourceLineNo">241</span> canTableBeDisabled = false;<a name="line.241"></a>
-<span class="sourceLineNo">242</span> }<a name="line.242"></a>
-<span class="sourceLineNo">243</span> }<a name="line.243"></a>
-<span class="sourceLineNo">244</span><a name="line.244"></a>
-<span class="sourceLineNo">245</span> // We are done the check. Future actions in this procedure could be done asynchronously.<a name="line.245"></a>
-<span class="sourceLineNo">246</span> releaseSyncLatch();<a name="line.246"></a>
-<span class="sourceLineNo">247</span><a name="line.247"></a>
-<span class="sourceLineNo">248</span> return canTableBeDisabled;<a name="line.248"></a>
-<span class="sourceLineNo">249</span> }<a name="line.249"></a>
-<span class="sourceLineNo">250</span><a name="line.250"></a>
-<span class="sourceLineNo">251</span> /**<a name="line.251"></a>
-<span class="sourceLineNo">252</span> * Action before disabling table.<a name="line.252"></a>
-<span class="sourceLineNo">253</span> * @param env MasterProcedureEnv<a name="line.253"></a>
-<span class="sourceLineNo">254</span> * @param state the procedure state<a name="line.254"></a>
-<span class="sourceLineNo">255</span> * @throws IOException<a name="line.255"></a>
-<span class="sourceLineNo">256</span> * @throws InterruptedException<a name="line.256"></a>
-<span class="sourceLineNo">257</span> */<a name="line.257"></a>
-<span class="sourceLineNo">258</span> protected void preDisable(final MasterProcedureEnv env, final DisableTableState state)<a name="line.258"></a>
-<span class="sourceLineNo">259</span> throws IOException, InterruptedException {<a name="line.259"></a>
-<span class="sourceLineNo">260</span> runCoprocessorAction(env, state);<a name="line.260"></a>
-<span class="sourceLineNo">261</span> }<a name="line.261"></a>
+<span class="sourceLineNo">050</span> private TableName tableName;<a name="line.50"></a>
+<span class="sourceLineNo">051</span> private boolean skipTableStateCheck;<a name="line.51"></a>
+<span class="sourceLineNo">052</span><a name="line.52"></a>
+<span class="sourceLineNo">053</span> private Boolean traceEnabled = null;<a name="line.53"></a>
+<span class="sourceLineNo">054</span><a name="line.54"></a>
+<span class="sourceLineNo">055</span> public DisableTableProcedure() {<a name="line.55"></a>
+<span class="sourceLineNo">056</span> super();<a name="line.56"></a>
+<span class="sourceLineNo">057</span> }<a name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span> /**<a name="line.59"></a>
+<span class="sourceLineNo">060</span> * Constructor<a name="line.60"></a>
+<span class="sourceLineNo">061</span> * @param env MasterProcedureEnv<a name="line.61"></a>
+<span class="sourceLineNo">062</span> * @param tableName the table to operate on<a name="line.62"></a>
+<span class="sourceLineNo">063</span> * @param skipTableStateCheck whether to check table state<a name="line.63"></a>
+<span class="sourceLineNo">064</span> */<a name="line.64"></a>
+<span class="sourceLineNo">065</span> public DisableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.65"></a>
+<span class="sourceLineNo">066</span> final boolean skipTableStateCheck)<a name="line.66"></a>
+<span class="sourceLineNo">067</span> throws HBaseIOException {<a name="line.67"></a>
+<span class="sourceLineNo">068</span> this(env, tableName, skipTableStateCheck, null);<a name="line.68"></a>
+<span class="sourceLineNo">069</span> }<a name="line.69"></a>
+<span class="sourceLineNo">070</span><a name="line.70"></a>
+<span class="sourceLineNo">071</span> /**<a name="line.71"></a>
+<span class="sourceLineNo">072</span> * Constructor<a name="line.72"></a>
+<span class="sourceLineNo">073</span> * @param env MasterProcedureEnv<a name="line.73"></a>
+<span class="sourceLineNo">074</span> * @param tableName the table to operate on<a name="line.74"></a>
+<span class="sourceLineNo">075</span> * @param skipTableStateCheck whether to check table state<a name="line.75"></a>
+<span class="sourceLineNo">076</span> */<a name="line.76"></a>
+<span class="sourceLineNo">077</span> public DisableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.77"></a>
+<span class="sourceLineNo">078</span> final boolean skipTableStateCheck, final ProcedurePrepareLatch syncLatch)<a name="line.78"></a>
+<span class="sourceLineNo">079</span> throws HBaseIOException {<a name="line.79"></a>
+<span class="sourceLineNo">080</span> super(env, syncLatch);<a name="line.80"></a>
+<span class="sourceLineNo">081</span> this.tableName = tableName;<a name="line.81"></a>
+<span class="sourceLineNo">082</span> preflightChecks(env, true);<a name="line.82"></a>
+<span class="sourceLineNo">083</span> this.skipTableStateCheck = skipTableStateCheck;<a name="line.83"></a>
+<span class="sourceLineNo">084</span> }<a name="line.84"></a>
+<span class="sourceLineNo">085</span><a name="line.85"></a>
+<span class="sourceLineNo">086</span> @Override<a name="line.86"></a>
+<span class="sourceLineNo">087</span> protected Flow executeFromState(final MasterProcedureEnv env, final DisableTableState state)<a name="line.87"></a>
+<span class="sourceLineNo">088</span> throws InterruptedException {<a name="line.88"></a>
+<span class="sourceLineNo">089</span> LOG.trace("{} execute state={}", this, state);<a name="line.89"></a>
+<span class="sourceLineNo">090</span> try {<a name="line.90"></a>
+<span class="sourceLineNo">091</span> switch (state) {<a name="line.91"></a>
+<span class="sourceLineNo">092</span> case DISABLE_TABLE_PREPARE:<a name="line.92"></a>
+<span class="sourceLineNo">093</span> if (prepareDisable(env)) {<a name="line.93"></a>
+<span class="sourceLineNo">094</span> setNextState(DisableTableState.DISABLE_TABLE_PRE_OPERATION);<a name="line.94"></a>
+<span class="sourceLineNo">095</span> } else {<a name="line.95"></a>
+<span class="sourceLineNo">096</span> assert isFailed() : "disable should have an exception here";<a name="line.96"></a>
+<span class="sourceLineNo">097</span> return Flow.NO_MORE_STATE;<a name="line.97"></a>
+<span class="sourceLineNo">098</span> }<a name="line.98"></a>
+<span class="sourceLineNo">099</span> break;<a name="line.99"></a>
+<span class="sourceLineNo">100</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.100"></a>
+<span class="sourceLineNo">101</span> preDisable(env, state);<a name="line.101"></a>
+<span class="sourceLineNo">102</span> setNextState(DisableTableState.DISABLE_TABLE_SET_DISABLING_TABLE_STATE);<a name="line.102"></a>
+<span class="sourceLineNo">103</span> break;<a name="line.103"></a>
+<span class="sourceLineNo">104</span> case DISABLE_TABLE_SET_DISABLING_TABLE_STATE:<a name="line.104"></a>
+<span class="sourceLineNo">105</span> setTableStateToDisabling(env, tableName);<a name="line.105"></a>
+<span class="sourceLineNo">106</span> setNextState(DisableTableState.DISABLE_TABLE_MARK_REGIONS_OFFLINE);<a name="line.106"></a>
+<span class="sourceLineNo">107</span> break;<a name="line.107"></a>
+<span class="sourceLineNo">108</span> case DISABLE_TABLE_MARK_REGIONS_OFFLINE:<a name="line.108"></a>
+<span class="sourceLineNo">109</span> addChildProcedure(env.getAssignmentManager().createUnassignProcedures(tableName));<a name="line.109"></a>
+<span class="sourceLineNo">110</span> setNextState(DisableTableState.DISABLE_TABLE_SET_DISABLED_TABLE_STATE);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> break;<a name="line.111"></a>
+<span class="sourceLineNo">112</span> case DISABLE_TABLE_ADD_REPLICATION_BARRIER:<a name="line.112"></a>
+<span class="sourceLineNo">113</span> if (env.getMasterServices().getTableDescriptors().get(tableName)<a name="line.113"></a>
+<span class="sourceLineNo">114</span> .hasGlobalReplicationScope()) {<a name="line.114"></a>
+<span class="sourceLineNo">115</span> MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();<a name="line.115"></a>
+<span class="sourceLineNo">116</span> try (BufferedMutator mutator = env.getMasterServices().getConnection()<a name="line.116"></a>
+<span class="sourceLineNo">117</span> .getBufferedMutator(TableName.META_TABLE_NAME)) {<a name="line.117"></a>
+<span class="sourceLineNo">118</span> for (RegionInfo region : env.getAssignmentManager().getRegionStates()<a name="line.118"></a>
+<span class="sourceLineNo">119</span> .getRegionsOfTable(tableName)) {<a name="line.119"></a>
+<span class="sourceLineNo">120</span> long maxSequenceId =<a name="line.120"></a>
+<span class="sourceLineNo">121</span> WALSplitter.getMaxRegionSequenceId(mfs.getFileSystem(), mfs.getRegionDir(region));<a name="line.121"></a>
+<span class="sourceLineNo">122</span> mutator.mutate(MetaTableAccessor.makePutForReplicationBarrier(region, maxSequenceId,<a name="line.122"></a>
+<span class="sourceLineNo">123</span> EnvironmentEdgeManager.currentTime()));<a name="line.123"></a>
+<span class="sourceLineNo">124</span> }<a name="line.124"></a>
+<span class="sourceLineNo">125</span> }<a name="line.125"></a>
+<span class="sourceLineNo">126</span> }<a name="line.126"></a>
+<span class="sourceLineNo">127</span> setNextState(DisableTableState.DISABLE_TABLE_SET_DISABLED_TABLE_STATE);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> break;<a name="line.128"></a>
+<span class="sourceLineNo">129</span> case DISABLE_TABLE_SET_DISABLED_TABLE_STATE:<a name="line.129"></a>
+<span class="sourceLineNo">130</span> setTableStateToDisabled(env, tableName);<a name="line.130"></a>
+<span class="sourceLineNo">131</span> setNextState(DisableTableState.DISABLE_TABLE_POST_OPERATION);<a name="line.131"></a>
+<span class="sourceLineNo">132</span> break;<a name="line.132"></a>
+<span class="sourceLineNo">133</span> case DISABLE_TABLE_POST_OPERATION:<a name="line.133"></a>
+<span class="sourceLineNo">134</span> postDisable(env, state);<a name="line.134"></a>
+<span class="sourceLineNo">135</span> return Flow.NO_MORE_STATE;<a name="line.135"></a>
+<span class="sourceLineNo">136</span> default:<a name="line.136"></a>
+<span class="sourceLineNo">137</span> throw new UnsupportedOperationException("Unhandled state=" + state);<a name="line.137"></a>
+<span class="sourceLineNo">138</span> }<a name="line.138"></a>
+<span class="sourceLineNo">139</span> } catch (IOException e) {<a name="line.139"></a>
+<span class="sourceLineNo">140</span> if (isRollbackSupported(state)) {<a name="line.140"></a>
+<span class="sourceLineNo">141</span> setFailure("master-disable-table", e);<a name="line.141"></a>
+<span class="sourceLineNo">142</span> } else {<a name="line.142"></a>
+<span class="sourceLineNo">143</span> LOG.warn("Retriable error trying to disable table={} (in state={})", tableName, state, e);<a name="line.143"></a>
+<span class="sourceLineNo">144</span> }<a name="line.144"></a>
+<span class="sourceLineNo">145</span> }<a name="line.145"></a>
+<span class="sourceLineNo">146</span> return Flow.HAS_MORE_STATE;<a name="line.146"></a>
+<span class="sourceLineNo">147</span> }<a name="line.147"></a>
+<span class="sourceLineNo">148</span><a name="line.148"></a>
+<span class="sourceLineNo">149</span> @Override<a name="line.149"></a>
+<span class="sourceLineNo">150</span> protected void rollbackState(final MasterProcedureEnv env, final DisableTableState state)<a name="line.150"></a>
+<span class="sourceLineNo">151</span> throws IOException {<a name="line.151"></a>
+<span class="sourceLineNo">152</span> // nothing to rollback, prepare-disable is just table-state checks.<a name="line.152"></a>
+<span class="sourceLineNo">153</span> // We can fail if the table does not exist or is not disabled.<a name="line.153"></a>
+<span class="sourceLineNo">154</span> switch (state) {<a name="line.154"></a>
+<span class="sourceLineNo">155</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.155"></a>
+<span class="sourceLineNo">156</span> return;<a name="line.156"></a>
+<span class="sourceLineNo">157</span> case DISABLE_TABLE_PREPARE:<a name="line.157"></a>
+<span class="sourceLineNo">158</span> releaseSyncLatch();<a name="line.158"></a>
+<span class="sourceLineNo">159</span> return;<a name="line.159"></a>
+<span class="sourceLineNo">160</span> default:<a name="line.160"></a>
+<span class="sourceLineNo">161</span> break;<a name="line.161"></a>
+<span class="sourceLineNo">162</span> }<a name="line.162"></a>
+<span class="sourceLineNo">163</span><a name="line.163"></a>
+<span class="sourceLineNo">164</span> // The delete doesn't have a rollback. The execution will succeed, at some point.<a name="line.164"></a>
+<span class="sourceLineNo">165</span> throw new UnsupportedOperationException("Unhandled state=" + state);<a name="line.165"></a>
+<span class="sourceLineNo">166</span> }<a name="line.166"></a>
+<span class="sourceLineNo">167</span><a name="line.167"></a>
+<span class="sourceLineNo">168</span> @Override<a name="line.168"></a>
+<span class="sourceLineNo">169</span> protected boolean isRollbackSupported(final DisableTableState state) {<a name="line.169"></a>
+<span class="sourceLineNo">170</span> switch (state) {<a name="line.170"></a>
+<span class="sourceLineNo">171</span> case DISABLE_TABLE_PREPARE:<a name="line.171"></a>
+<span class="sourceLineNo">172</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.172"></a>
+<span class="sourceLineNo">173</span> return true;<a name="line.173"></a>
+<span class="sourceLineNo">174</span> default:<a name="line.174"></a>
+<span class="sourceLineNo">175</span> return false;<a name="line.175"></a>
+<span class="sourceLineNo">176</span> }<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span><a name="line.178"></a>
+<span class="sourceLineNo">179</span> @Override<a name="line.179"></a>
+<span class="sourceLineNo">180</span> protected DisableTableState getState(final int stateId) {<a name="line.180"></a>
+<span class="sourceLineNo">181</span> return DisableTableState.valueOf(stateId);<a name="line.181"></a>
+<span class="sourceLineNo">182</span> }<a name="line.182"></a>
+<span class="sourceLineNo">183</span><a name="line.183"></a>
+<span class="sourceLineNo">184</span> @Override<a name="line.184"></a>
+<span class="sourceLineNo">185</span> protected int getStateId(final DisableTableState state) {<a name="line.185"></a>
+<span class="sourceLineNo">186</span> return state.getNumber();<a name="line.186"></a>
+<span class="sourceLineNo">187</span> }<a name="line.187"></a>
+<span class="sourceLineNo">188</span><a name="line.188"></a>
+<span class="sourceLineNo">189</span> @Override<a name="line.189"></a>
+<span class="sourceLineNo">190</span> protected DisableTableState getInitialState() {<a name="line.190"></a>
+<span class="sourceLineNo">191</span> return DisableTableState.DISABLE_TABLE_PREPARE;<a name="line.191"></a>
+<span class="sourceLineNo">192</span> }<a name="line.192"></a>
+<span class="sourceLineNo">193</span><a name="line.193"></a>
+<span class="sourceLineNo">194</span> @Override<a name="line.194"></a>
+<span class="sourceLineNo">195</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.195"></a>
+<span class="sourceLineNo">196</span> throws IOException {<a name="line.196"></a>
+<span class="sourceLineNo">197</span> super.serializeStateData(serializer);<a name="line.197"></a>
+<span class="sourceLineNo">198</span><a name="line.198"></a>
+<span class="sourceLineNo">199</span> MasterProcedureProtos.DisableTableStateData.Builder disableTableMsg =<a name="line.199"></a>
+<span class="sourceLineNo">200</span> MasterProcedureProtos.DisableTableStateData.newBuilder()<a name="line.200"></a>
+<span class="sourceLineNo">201</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.201"></a>
+<span class="sourceLineNo">202</span> .setTableName(ProtobufUtil.toProtoTableName(tableName))<a name="line.202"></a>
+<span class="sourceLineNo">203</span> .setSkipTableStateCheck(skipTableStateCheck);<a name="line.203"></a>
+<span class="sourceLineNo">204</span><a name="line.204"></a>
+<span class="sourceLineNo">205</span> serializer.serialize(disableTableMsg.build());<a name="line.205"></a>
+<span class="sourceLineNo">206</span> }<a name="line.206"></a>
+<span class="sourceLineNo">207</span><a name="line.207"></a>
+<span class="sourceLineNo">208</span> @Override<a name="line.208"></a>
+<span class="sourceLineNo">209</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.209"></a>
+<span class="sourceLineNo">210</span> throws IOException {<a name="line.210"></a>
+<span class="sourceLineNo">211</span> super.deserializeStateData(serializer);<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span> MasterProcedureProtos.DisableTableStateData disableTableMsg =<a name="line.213"></a>
+<span class="sourceLineNo">214</span> serializer.deserialize(MasterProcedureProtos.DisableTableStateData.class);<a name="line.214"></a>
+<span class="sourceLineNo">215</span> setUser(MasterProcedureUtil.toUserInfo(disableTableMsg.getUserInfo()));<a name="line.215"></a>
+<span class="sourceLineNo">216</span> tableName = ProtobufUtil.toTableName(disableTableMsg.getTableName());<a name="line.216"></a>
+<span class="sourceLineNo">217</span> skipTableStateCheck = disableTableMsg.getSkipTableStateCheck();<a name="line.217"></a>
+<span class="sourceLineNo">218</span> }<a name="line.218"></a>
+<span class="sourceLineNo">219</span><a name="line.219"></a>
+<span class="sourceLineNo">220</span> @Override<a name="line.220"></a>
+<span class="sourceLineNo">221</span> public TableName getTableName() {<a name="line.221"></a>
+<span class="sourceLineNo">222</span> return tableName;<a name="line.222"></a>
+<span class="sourceLineNo">223</span> }<a name="line.223"></a>
+<span class="sourceLineNo">224</span><a name="line.224"></a>
+<span class="sourceLineNo">225</span> @Override<a name="line.225"></a>
+<span class="sourceLineNo">226</span> public TableOperationType getTableOperationType() {<a name="line.226"></a>
+<span class="sourceLineNo">227</span> return TableOperationType.DISABLE;<a name="line.227"></a>
+<span class="sourceLineNo">228</span> }<a name="line.228"></a>
+<span class="sourceLineNo">229</span><a name="line.229"></a>
+<span class="sourceLineNo">230</span> /**<a name="line.230"></a>
+<span class="sourceLineNo">231</span> * Action before any real action of disabling table. Set the exception in the procedure instead<a name="line.231"></a>
+<span class="sourceLineNo">232</span> * of throwing it. This approach is to deal with backward compatible with 1.0.<a name="line.232"></a>
+<span class="sourceLineNo">233</span> * @param env MasterProcedureEnv<a name="line.233"></a>
+<span class="sourceLineNo">234</span> * @throws IOException<a name="line.234"></a>
+<span class="sourceLineNo">235</span> */<a name="line.235"></a>
+<span class="sourceLineNo">236</span> private boolean prepareDisable(final MasterProcedureEnv env) throws IOException {<a name="line.236"></a>
+<span class="sourceLineNo">237</span> boolean canTableBeDisabled = true;<a name="line.237"></a>
+<span class="sourceLineNo">238</span> if (tableName.equals(TableName.META_TABLE_NAME)) {<a name="line.238"></a>
+<span class="sourceLineNo">239</span> setFailure("master-disable-table", new ConstraintException("Cannot disable catalog table"));<a name="line.239"></a>
+<span class="sourceLineNo">240</span> canTableBeDisabled = false;<a name="line.240"></a>
+<span class="sourceLineNo">241</span> } else if (!MetaTableAccessor.tableExists(env.getMasterServices().getConnection(), tableName)) {<a name="line.241"></a>
+<span class="sourceLineNo">242</span> setFailure("master-disable-table", new TableNotFoundException(tableName));<a name="line.242"></a>
+<span class="sourceLineNo">243</span> canTableBeDisabled = false;<a name="line.243"></a>
+<span class="sourceLineNo">244</span> } else if (!skipTableStateCheck) {<a name="line.244"></a>
+<span class="sourceLineNo">245</span> // There could be multiple client requests trying to disable or enable<a name="line.245"></a>
+<span class="sourceLineNo">246</span> // the table at the same time. Ensure only the first request is honored<a name="line.246"></a>
+<span class="sourceLineNo">247</span> // After that, no other requests can be accepted until the table reaches<a name="line.247"></a>
+<span class="sourceLineNo">248</span> // DISABLED or ENABLED.<a name="line.248"></a>
+<span class="sourceLineNo">249</span> //<a name="line.249"></a>
+<span class="sourceLineNo">250</span> // Note: in 1.0 release, we called TableStateManager.setTableStateIfInStates() to set<a name="line.250"></a>
+<span class="sourceLineNo">251</span> // the state to DISABLING from ENABLED. The implementation was done before table lock<a name="line.251"></a>
+<span class="sourceLineNo">252</span> // was implemented. With table lock, there is no need to set the state here (it will<a name="line.252"></a>
+<span class="sourceLineNo">253</span> // set the state later on). A quick state check should be enough for us to move forward.<a name="line.253"></a>
+<span class="sourceLineNo">254</span> TableStateManager tsm = env.getMasterServices().getTableStateManager();<a name="line.254"></a>
+<span class="sourceLineNo">255</span> TableState ts = tsm.getTableState(tableName);<a name="line.255"></a>
+<span class="sourceLineNo">256</span> if (!ts.isEnabled()) {<a name="line.256"></a>
+<span class="sourceLineNo">257</span> LOG.info("Not ENABLED tableState=" + ts + "; skipping disable");<a name="line.257"></a>
+<span class="sourceLineNo">258</span> setFailure("master-disable-table", new TableNotEnabledException(ts.toString()));<a name="line.258"></a>
+<span class="sourceLineNo">259</span> canTableBeDisabled = false;<a name="line.259"></a>
+<span class="sourceLineNo">260</span> }<a name="line.260"></a>
+<span class="sourceLineNo">261</span> }<a name="line.261"></a>
<span class="sourceLineNo">262</span><a name="line.262"></a>
-<span class="sourceLineNo">263</span> /**<a name="line.263"></a>
-<span class="sourceLineNo">264</span> * Mark table state to Disabling<a name="line.264"></a>
-<span class="sourceLineNo">265</span> * @param env MasterProcedureEnv<a name="line.265"></a>
-<span class="sourceLineNo">266</span> * @throws IOException<a name="line.266"></a>
-<span class="sourceLineNo">267</span> */<a name="line.267"></a>
-<span class="sourceLineNo">268</span> protected static void setTableStateToDisabling(<a name="line.268"></a>
-<span class="sourceLineNo">269</span> final MasterProcedureEnv env,<a name="line.269"></a>
-<span class="sourceLineNo">270</span> final TableName tableName) throws IOException {<a name="line.270"></a>
-<span class="sourceLineNo">271</span> // Set table disabling flag up in zk.<a name="line.271"></a>
-<span class="sourceLineNo">272</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.272"></a>
-<span class="sourceLineNo">273</span> tableName,<a name="line.273"></a>
-<span class="sourceLineNo">274</span> TableState.State.DISABLING);<a name="line.274"></a>
-<span class="sourceLineNo">275</span> }<a name="line.275"></a>
-<span class="sourceLineNo">276</span><a name="line.276"></a>
-<span class="sourceLineNo">277</span> /**<a name="line.277"></a>
-<span class="sourceLineNo">278</span> * Mark table state to Disabled<a name="line.278"></a>
-<span class="sourceLineNo">279</span> * @param env MasterProcedureEnv<a name="line.279"></a>
-<span class="sourceLineNo">280</span> * @throws IOException<a name="line.280"></a>
-<span class="sourceLineNo">281</span> */<a name="line.281"></a>
-<span class="sourceLineNo">282</span> protected static void setTableStateToDisabled(<a name="line.282"></a>
-<span class="sourceLineNo">283</span> final MasterProcedureEnv env,<a name="line.283"></a>
-<span class="sourceLineNo">284</span> final TableName tableName) throws IOException {<a name="line.284"></a>
-<span class="sourceLineNo">285</span> // Flip the table to disabled<a name="line.285"></a>
-<span class="sourceLineNo">286</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.286"></a>
-<span class="sourceLineNo">287</span> tableName,<a name="line.287"></a>
-<span class="sourceLineNo">288</span> TableState.State.DISABLED);<a name="line.288"></a>
-<span class="sourceLineNo">289</span> LOG.info("Disabled table, " + tableName + ", is completed.");<a name="line.289"></a>
-<span class="sourceLineNo">290</span> }<a name="line.290"></a>
-<span class="sourceLineNo">291</span><a name="line.291"></a>
-<span class="sourceLineNo">292</span> /**<a name="line.292"></a>
-<span class="sourceLineNo">293</span> * Action after disabling table.<a name="line.293"></a>
-<span class="sourceLineNo">294</span> * @param env MasterProcedureEnv<a name="line.294"></a>
-<span class="sourceLineNo">295</span> * @param state the procedure state<a name="line.295"></a>
-<span class="sourceLineNo">296</span> * @throws IOException<a name="line.296"></a>
-<span class="sourceLineNo">297</span> * @throws InterruptedException<a name="line.297"></a>
-<span class="sourceLineNo">298</span> */<a name="line.298"></a>
-<span class="sourceLineNo">299</span> protected void postDisable(final MasterProcedureEnv env, final DisableTableState state)<a name="line.299"></a>
-<span class="sourceLineNo">300</span> throws IOException, InterruptedException {<a name="line.300"></a>
-<span class="sourceLineNo">301</span> runCoprocessorAction(env, state);<a name="line.301"></a>
-<span class="sourceLineNo">302</span> }<a name="line.302"></a>
-<span class="sourceLineNo">303</span><a name="line.303"></a>
-<span class="sourceLineNo">304</span> /**<a name="line.304"></a>
-<span class="sourceLineNo">305</span> * The procedure could be restarted from a different machine. If the variable is null, we need to<a name="line.305"></a>
-<span class="sourceLineNo">306</span> * retrieve it.<a name="line.306"></a>
-<span class="sourceLineNo">307</span> * @return traceEnabled<a name="line.307"></a>
-<span class="sourceLineNo">308</span> */<a name="line.308"></a>
-<span class="sourceLineNo">309</span> private Boolean isTraceEnabled() {<a name="line.309"></a>
-<span class="sourceLineNo">310</span> if (traceEnabled == null) {<a name="line.310"></a>
-<span class="sourceLineNo">311</span> traceEnabled = LOG.isTraceEnabled();<a name="line.311"></a>
-<span class="sourceLineNo">312</span> }<a name="line.312"></a>
-<span class="sourceLineNo">313</span> return traceEnabled;<a name="line.313"></a>
-<span class="sourceLineNo">314</span> }<a name="line.314"></a>
-<span class="sourceLineNo">315</span><a name="line.315"></a>
-<span class="sourceLineNo">316</span> /**<a name="line.316"></a>
-<span class="sourceLineNo">317</span> * Coprocessor Action.<a name="line.317"></a>
-<span class="sourceLineNo">318</span> * @param env MasterProcedureEnv<a name="line.318"></a>
-<span class="sourceLineNo">319</span> * @param state the procedure state<a name="line.319"></a>
-<span class="sourceLineNo">320</span> * @throws IOException<a name="line.320"></a>
-<span class="sourceLineNo">321</span> * @throws InterruptedException<a name="line.321"></a>
-<span class="sourceLineNo">322</span> */<a name="line.322"></a>
-<span class="sourceLineNo">323</span> private void runCoprocessorAction(final MasterProcedureEnv env, final DisableTableState state)<a name="line.323"></a>
-<span class="sourceLineNo">324</span> throws IOException, InterruptedException {<a name="line.324"></a>
-<span class="sourceLineNo">325</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.325"></a>
-<span class="sourceLineNo">326</span> if (cpHost != null) {<a name="line.326"></a>
-<span class="sourceLineNo">327</span> switch (state) {<a name="line.327"></a>
-<span class="sourceLineNo">328</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.328"></a>
-<span class="sourceLineNo">329</span> cpHost.preDisableTableAction(tableName, getUser());<a name="line.329"></a>
-<span class="sourceLineNo">330</span> break;<a name="line.330"></a>
-<span class="sourceLineNo">331</span> case DISABLE_TABLE_POST_OPERATION:<a name="line.331"></a>
-<span class="sourceLineNo">332</span> cpHost.postCompletedDisableTableAction(tableName, getUser());<a name="line.332"></a>
-<span class="sourceLineNo">333</span> break;<a name="line.333"></a>
-<span class="sourceLineNo">334</span> default:<a name="line.334"></a>
-<span class="sourceLineNo">335</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.335"></a>
-<span class="sourceLineNo">336</span> }<a name="line.336"></a>
-<span class="sourceLineNo">337</span> }<a name="line.337"></a>
-<span class="sourceLineNo">338</span> }<a name="line.338"></a>
-<span class="sourceLineNo">339</span>}<a name="line.339"></a>
+<span class="sourceLineNo">263</span> // We are done the check. Future actions in this procedure could be done asynchronously.<a name="line.263"></a>
+<span class="sourceLineNo">264</span> releaseSyncLatch();<a name="line.264"></a>
+<span class="sourceLineNo">265</span><a name="line.265"></a>
+<span class="sourceLineNo">266</span> return canTableBeDisabled;<a name="line.266"></a>
+<span class="sourceLineNo">267</span> }<a name="line.267"></a>
+<span class="sourceLineNo">268</span><a name="line.268"></a>
+<span class="sourceLineNo">269</span> /**<a name="line.269"></a>
+<span class="sourceLineNo">270</span> * Action before disabling table.<a name="line.270"></a>
+<span class="sourceLineNo">271</span> * @param env MasterProcedureEnv<a name="line.271"></a>
+<span class="sourceLineNo">272</span> * @param state the procedure state<a name="line.272"></a>
+<span class="sourceLineNo">273</span> * @throws IOException<a name="line.273"></a>
+<span class="sourceLineNo">274</span> * @throws InterruptedException<a name="line.274"></a>
+<span class="sourceLineNo">275</span> */<a name="line.275"></a>
+<span class="sourceLineNo">276</span> protected void preDisable(final MasterProcedureEnv env, final DisableTableState state)<a name="line.276"></a>
+<span class="sourceLineNo">277</span> throws IOException, InterruptedException {<a name="line.277"></a>
+<span class="sourceLineNo">278</span> runCoprocessorAction(env, state);<a name="line.278"></a>
+<span class="sourceLineNo">279</span> }<a name="line.279"></a>
+<span class="sourceLineNo">280</span><a name="line.280"></a>
+<span class="sourceLineNo">281</span> /**<a name="line.281"></a>
+<span class="sourceLineNo">282</span> * Mark table state to Disabling<a name="line.282"></a>
+<span class="sourceLineNo">283</span> * @param env MasterProcedureEnv<a name="line.283"></a>
+<span class="sourceLineNo">284</span> * @throws IOException<a name="line.284"></a>
+<span class="sourceLineNo">285</span> */<a name="line.285"></a>
+<span class="sourceLineNo">286</span> protected static void setTableStateToDisabling(<a name="line.286"></a>
+<span class="sourceLineNo">287</span> final MasterProcedureEnv env,<a name="line.287"></a>
+<span class="sourceLineNo">288</span> final TableName tableName) throws IOException {<a name="line.288"></a>
+<span class="sourceLineNo">289</span> // Set table disabling flag up in zk.<a name="line.289"></a>
+<span class="sourceLineNo">290</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.290"></a>
+<span class="sourceLineNo">291</span> tableName,<a name="line.291"></a>
+<span class="sourceLineNo">292</span> TableState.State.DISABLING);<a name="line.292"></a>
+<span class="sourceLineNo">293</span> }<a name="line.293"></a>
+<span class="sourceLineNo">294</span><a name="line.294"></a>
+<span class="sourceLineNo">295</span> /**<a name="line.295"></a>
+<span class="sourceLineNo">296</span> * Mark table state to Disabled<a name="line.296"></a>
+<span class="sourceLineNo">297</span> * @param env MasterProcedureEnv<a name="line.297"></a>
+<span class="sourceLineNo">298</span> * @throws IOException<a name="line.298"></a>
+<span class="sourceLineNo">299</span> */<a name="line.299"></a>
+<span class="sourceLineNo">300</span> protected static void setTableStateToDisabled(<a name="line.300"></a>
+<span class="sourceLineNo">301</span> final MasterProcedureEnv env,<a name="line.301"></a>
+<span class="sourceLineNo">302</span> final TableName tableName) throws IOException {<a name="line.302"></a>
+<span class="sourceLineNo">303</span> // Flip the table to disabled<a name="line.303"></a>
+<span class="sourceLineNo">304</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.304"></a>
+<span class="sourceLineNo">305</span> tableName,<a name="line.305"></a>
+<span class="sourceLineNo">306</span> TableState.State.DISABLED);<a name="line.306"></a>
+<span class="sourceLineNo">307</span> LOG.info("Disabled table, " + tableName + ", is completed.");<a name="line.307"></a>
+<span class="sourceLineNo">308</span> }<a name="line.308"></a>
+<span class="sourceLineNo">309</span><a name="line.309"></a>
+<span class="sourceLineNo">310</span> /**<a name="line.310"></a>
+<span class="sourceLineNo">311</span> * Action after disabling table.<a name="line.311"></a>
+<span class="sourceLineNo">312</span> * @param env MasterProcedureEnv<a name="line.312"></a>
+<span class="sourceLineNo">313</span> * @param state the procedure state<a name="line.313"></a>
+<span class="sourceLineNo">314</span> * @throws IOException<a name="line.314"></a>
+<span class="sourceLineNo">315</span> * @throws InterruptedException<a name="line.315"></a>
+<span class="sourceLineNo">316</span> */<a name="line.316"></a>
+<span class="sourceLineNo">317</span> protected void postDisable(final MasterProcedureEnv env, final DisableTableState state)<a name="line.317"></a>
+<span class="sourceLineNo">318</span> throws IOException, InterruptedException {<a name="line.318"></a>
+<span class="sourceLineNo">319</span> runCoprocessorAction(env, state);<a name="line.319"></a>
+<span class="sourceLineNo">320</span> }<a name="line.320"></a>
+<span class="sourceLineNo">321</span><a name="line.321"></a>
+<span class="sourceLineNo">322</span> /**<a name="line.322"></a>
+<span class="sourceLineNo">323</span> * The procedure could be restarted from a different machine. If the variable is null, we need to<a name="line.323"></a>
+<span class="sourceLineNo">324</span> * retrieve it.<a name="line.324"></a>
+<span class="sourceLineNo">325</span> * @return traceEnabled<a name="line.325"></a>
+<span class="sourceLineNo">326</span> */<a name="line.326"></a>
+<span class="sourceLineNo">327</span> private Boolean isTraceEnabled() {<a name="line.327"></a>
+<span class="sourceLineNo">328</span> if (traceEnabled == null) {<a name="line.328"></a>
+<span class="sourceLineNo">329</span> traceEnabled = LOG.isTraceEnabled();<a name="line.329"></a>
+<span class="sourceLineNo">330</span> }<a name="line.330"></a>
+<span class="sourceLineNo">331</span> return traceEnabled;<a name="line.331"></a>
+<span class="sourceLineNo">332</span> }<a name="line.332"></a>
+<span class="sourceLineNo">333</span><a name="line.333"></a>
+<span class="sourceLineNo">334</span> /**<a name="line.334"></a>
+<span class="sourceLineNo">335</span> * Coprocessor Action.<a name="line.335"></a>
+<span class="sourceLineNo">336</span> * @param env MasterProcedureEnv<a name="line.336"></a>
+<span class="sourceLineNo">337</span> * @param state the procedure state<a name="line.337"></a>
+<span class="sourceLineNo">338</span> * @throws IOException<a name="line.338"></a>
+<span class="sourceLineNo">339</span> * @throws InterruptedException<a name="line.339"></a>
+<span class="sourceLineNo">340</span> */<a name="line.340"></a>
+<span class="sourceLineNo">341</span> private void runCoprocessorAction(final MasterProcedureEnv env, final DisableTableState state)<a name="line.341"></a>
+<span class="sourceLineNo">342</span> throws IOException, InterruptedException {<a name="line.342"></a>
+<span class="sourceLineNo">343</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.343"></a>
+<span class="sourceLineNo">344</span> if (cpHost != null) {<a name="line.344"></a>
+<span class="sourceLineNo">345</span> switch (state) {<a name="line.345"></a>
+<span class="sourceLineNo">346</span> case DISABLE_TABLE_PRE_OPERATION:<a name="line.346"></a>
+<span class="sourceLineNo">347</span> cpHost.preDisableTableAction(tableName, getUser());<a name="line.347"></a>
+<span class="sourceLineNo">348</span> break;<a name="line.348"></a>
+<span class="sourceLineNo">349</span> case DISABLE_TABLE_POST_OPERATION:<a name="line.349"></a>
+<span class="sourceLineNo">350</span> cpHost.postCompletedDisableTableAction(tableName, getUser());<a name="line.350"></a>
+<span class="sourceLineNo">351</span> break;<a name="line.351"></a>
+<span class="sourceLineNo">352</span> default:<a name="line.352"></a>
+<span class="sourceLineNo">353</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.353"></a>
+<span class="sourceLineNo">354</span> }<a name="line.354"></a>
+<span class="sourceLineNo">355</span> }<a name="line.355"></a>
+<span class="sourceLineNo">356</span> }<a name="line.356"></a>
+<span class="sourceLineNo">357</span>}<a name="line.357"></a>