You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Prashant Satam <pr...@gmail.com> on 2023/12/19 10:26:52 UTC

Review Request 74799: RANGER-4618: Need to add displayName field in zoneSummary Object

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74799/
-----------------------------------------------------------

Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, Subhrat Chaudhary, and Vanita Ubale.


Bugs: RANGER-4618
    https://issues.apache.org/jira/browse/RANGER-4618


Repository: ranger


Description
-------

In the zoneSummary Object services section we have name field to display serviceName but it will be helpful if we add displayName field also to the same


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java 4ea6cdee6 
  security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 422dd0fe5 


Diff: https://reviews.apache.org/r/74799/diff/1/


Testing
-------

1)create a securityZone by adding a service to it 
2)get securityZone by (/service/zones/summary/) you will get displayName field in zoneSummaryList

Request ====> /service/zones/summary

Response ======> 
{
    "startIndex": 0,
    "pageSize": 1,
    "totalCount": 5,
    "resultSize": 1,
    "sortType": null,
    "sortBy": null,
    "queryTimeMS": 1702981470678,
    "list": [
        {
            "id": 2,
            "isEnabled": true,
            "createdBy": "Admin",
            "updatedBy": "Admin",
            "createTime": 1699352435000,
            "updateTime": 1701843223000,
            "name": "Test-Zone-1",
            "description": "ZZ",
            "totalResourceCount": 1,
            "adminCount": {
                "GROUP": 0,
                "ROLE": 1,
                "USER": 2
            },
            "auditorCount": {
                "GROUP": 0,
                "ROLE": 0,
                "USER": 1
            },
            "services": [
                {
                    "id": 1,
                    "name": "Ranger_hive",
                    "type": "hive",
                    "displayName": "Ranger_hive_DISPLAY",
                    "resourceCount": 1
                }
            ]
        }
    ],
    "listSize": 1
}


Thanks,

Prashant Satam


Re: Review Request 74799: RANGER-4618: Need to add displayName field in zoneSummary Object

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74799/#review226065
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 19, 2023, 10:26 a.m., Prashant Satam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74799/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2023, 10:26 a.m.)
> 
> 
> Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, Subhrat Chaudhary, and Vanita Ubale.
> 
> 
> Bugs: RANGER-4618
>     https://issues.apache.org/jira/browse/RANGER-4618
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> In the zoneSummary Object services section we have name field to display serviceName but it will be helpful if we add displayName field also to the same
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java 4ea6cdee6 
>   security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java 422dd0fe5 
> 
> 
> Diff: https://reviews.apache.org/r/74799/diff/1/
> 
> 
> Testing
> -------
> 
> 1)create a securityZone by adding a service to it 
> 2)get securityZone by (/service/zones/summary/) you will get displayName field in zoneSummaryList
> 
> Request ====> /service/zones/summary
> 
> Response ======> 
> {
>     "startIndex": 0,
>     "pageSize": 1,
>     "totalCount": 5,
>     "resultSize": 1,
>     "sortType": null,
>     "sortBy": null,
>     "queryTimeMS": 1702981470678,
>     "list": [
>         {
>             "id": 2,
>             "isEnabled": true,
>             "createdBy": "Admin",
>             "updatedBy": "Admin",
>             "createTime": 1699352435000,
>             "updateTime": 1701843223000,
>             "name": "Test-Zone-1",
>             "description": "ZZ",
>             "totalResourceCount": 1,
>             "adminCount": {
>                 "GROUP": 0,
>                 "ROLE": 1,
>                 "USER": 2
>             },
>             "auditorCount": {
>                 "GROUP": 0,
>                 "ROLE": 0,
>                 "USER": 1
>             },
>             "services": [
>                 {
>                     "id": 1,
>                     "name": "Ranger_hive",
>                     "type": "hive",
>                     "displayName": "Ranger_hive_DISPLAY",
>                     "resourceCount": 1
>                 }
>             ]
>         }
>     ],
>     "listSize": 1
> }
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>