Re: [PR] ARTEMIS-4545 Allow node ID to be configured [activemq-artemis]

["gtully (via GitHub)" <gi...@apache.org>]

gtully commented on PR #4951:
URL: https://github.com/apache/activemq-artemis/pull/4951#issuecomment-2149567599

   Have you seen: https://github.com/apache/activemq-artemis/blob/576622571a839720d83d800b12a7f2b2448b30d9/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ReplicationPrimaryActivation.java#L171
   
   with the zk locker we can have peer brokers that coordinate on a shared node id. it is called the coordinator-id in the zk activation config, but ends up as the node-id. With the potential for unknown backups with replication, the node id has to be reset. However this new config could make it simpler for pure peers, where there is no replication b/c the it is non persistent or uses a shared store.
   
   I guess we need to allow these to coexist or document that they must be used independently. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact