You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/07/10 05:44:08 UTC
[kudu-CR] KUDU-2797: the master aggregates tablet statistics
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet statistics
......................................................................
Patch Set 19:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13426/17/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:
http://gerrit.cloudera.org:8080/#/c/13426/17/src/kudu/tserver/ts_tablet_manager.cc@1307
PS17, Line 1307: {
: ReportedTabletStatsPB stats_pb = replica->stats_pb();
: if (stats_pb.IsInitialized()) {
: *reported_tablet->mutable_stats() = std::move(stats_pb);
: }
: }
> Yeah, the `if` statement is fine, I just meant the extra curly braces.
Done
--
To view, visit http://gerrit.cloudera.org:8080/13426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99
Gerrit-Change-Number: 13426
Gerrit-PatchSet: 19
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 05:44:08 +0000
Gerrit-HasComments: Yes