You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by li...@apache.org on 2024/03/19 03:11:53 UTC

(flink-docker) branch master updated: [FLINK-34701][release] Update docker-entrypoint.sh for 1.19.0

This is an automated email from the ASF dual-hosted git repository.

lincoln pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-docker.git


The following commit(s) were added to refs/heads/master by this push:
     new 20017e8  [FLINK-34701][release] Update docker-entrypoint.sh for 1.19.0
20017e8 is described below

commit 20017e8f0e81d54fe74c0f9f6a3a988ea609be8f
Author: lincoln lee <li...@gmail.com>
AuthorDate: Tue Mar 19 11:11:48 2024 +0800

    [FLINK-34701][release] Update docker-entrypoint.sh for 1.19.0
    
    This closes #189
---
 1.19/scala_2.12-java11-ubuntu/docker-entrypoint.sh | 8 ++++----
 1.19/scala_2.12-java17-ubuntu/docker-entrypoint.sh | 8 ++++----
 1.19/scala_2.12-java8-ubuntu/docker-entrypoint.sh  | 8 ++++----
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/1.19/scala_2.12-java11-ubuntu/docker-entrypoint.sh b/1.19/scala_2.12-java11-ubuntu/docker-entrypoint.sh
index e884375..e081109 100755
--- a/1.19/scala_2.12-java11-ubuntu/docker-entrypoint.sh
+++ b/1.19/scala_2.12-java11-ubuntu/docker-entrypoint.sh
@@ -65,19 +65,19 @@ set_config_options() {
     local bin_dir="$FLINK_HOME/bin"
     local lib_dir="$FLINK_HOME/lib"
 
-    local config_params=""
+    local config_params=()
 
     while [ $# -gt 0 ]; do
         local key="$1"
         local value="$2"
 
-        config_params+=" -D${key}=${value}"
+        config_params+=("-D${key}=${value}")
 
         shift 2
     done
 
-    if [ ! -z "${config_params}" ]; then
-        eval "${config_parser_script} ${config_dir} ${bin_dir} ${lib_dir} ${config_params}"
+    if [ "${#config_params[@]}" -gt 0 ]; then
+        "${config_parser_script}" "${config_dir}" "${bin_dir}" "${lib_dir}" "${config_params[@]}"
     fi
 }
 
diff --git a/1.19/scala_2.12-java17-ubuntu/docker-entrypoint.sh b/1.19/scala_2.12-java17-ubuntu/docker-entrypoint.sh
index e884375..e081109 100755
--- a/1.19/scala_2.12-java17-ubuntu/docker-entrypoint.sh
+++ b/1.19/scala_2.12-java17-ubuntu/docker-entrypoint.sh
@@ -65,19 +65,19 @@ set_config_options() {
     local bin_dir="$FLINK_HOME/bin"
     local lib_dir="$FLINK_HOME/lib"
 
-    local config_params=""
+    local config_params=()
 
     while [ $# -gt 0 ]; do
         local key="$1"
         local value="$2"
 
-        config_params+=" -D${key}=${value}"
+        config_params+=("-D${key}=${value}")
 
         shift 2
     done
 
-    if [ ! -z "${config_params}" ]; then
-        eval "${config_parser_script} ${config_dir} ${bin_dir} ${lib_dir} ${config_params}"
+    if [ "${#config_params[@]}" -gt 0 ]; then
+        "${config_parser_script}" "${config_dir}" "${bin_dir}" "${lib_dir}" "${config_params[@]}"
     fi
 }
 
diff --git a/1.19/scala_2.12-java8-ubuntu/docker-entrypoint.sh b/1.19/scala_2.12-java8-ubuntu/docker-entrypoint.sh
index e884375..e081109 100755
--- a/1.19/scala_2.12-java8-ubuntu/docker-entrypoint.sh
+++ b/1.19/scala_2.12-java8-ubuntu/docker-entrypoint.sh
@@ -65,19 +65,19 @@ set_config_options() {
     local bin_dir="$FLINK_HOME/bin"
     local lib_dir="$FLINK_HOME/lib"
 
-    local config_params=""
+    local config_params=()
 
     while [ $# -gt 0 ]; do
         local key="$1"
         local value="$2"
 
-        config_params+=" -D${key}=${value}"
+        config_params+=("-D${key}=${value}")
 
         shift 2
     done
 
-    if [ ! -z "${config_params}" ]; then
-        eval "${config_parser_script} ${config_dir} ${bin_dir} ${lib_dir} ${config_params}"
+    if [ "${#config_params[@]}" -gt 0 ]; then
+        "${config_parser_script}" "${config_dir}" "${bin_dir}" "${lib_dir}" "${config_params[@]}"
     fi
 }