You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/03 04:28:33 UTC

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15654: [admin][txn] Add transaction admin to get recover time in stats.

liangyepianzhou commented on code in PR #15654:
URL: https://github.com/apache/pulsar/pull/15654#discussion_r888599336


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -147,6 +150,7 @@ private void initPendingAckStore() {
                 this.pendingAckStoreFuture =
                         pendingAckStoreProvider.newPendingAckStore(persistentSubscription);
                 this.pendingAckStoreFuture.thenAccept(pendingAckStore -> {
+                    recoverTime.setRecoverStartTime(System.currentTimeMillis());

Review Comment:
   Transaction pending ack is lazy loading. There may not start to recover.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org