You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2016/04/19 23:57:25 UTC

[jira] [Commented] (WICKET-6148) Remove AjaxEventBehavior#onCheckEvent() before Wicket 8.0.0

    [ https://issues.apache.org/jira/browse/WICKET-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248762#comment-15248762 ] 

ASF subversion and git services commented on WICKET-6148:
---------------------------------------------------------

Commit 20cf8ee341a0aab994c9e9a102687a9a3e88e27a in wicket's branch refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=20cf8ee ]

WICKET-6148 Remove AjaxEventBehavior#onCheckEvent() before Wicket 8.0.0


> Remove AjaxEventBehavior#onCheckEvent() before Wicket 8.0.0
> -----------------------------------------------------------
>
>                 Key: WICKET-6148
>                 URL: https://issues.apache.org/jira/browse/WICKET-6148
>             Project: Wicket
>          Issue Type: Task
>          Components: wicket
>            Reporter: Martin Grigorov
>            Priority: Minor
>             Fix For: 8.0.0
>
>
> org.apache.wicket.ajax.AjaxEventBehavior#onCheckEvent() will throw an exception if the event name starts with 'on', e.g. 'onclick'.
> Since version 6.0.0 Wicket uses JavaScript based event registration and the prefix 'on' is actually wrong. It has been used for pre-1.5 versions for the attribute names.
> There are valid use cases where applications may use custom JS events with names which start with 'on', so Wicket should not prevent them.
> During the milestone release org.apache.wicket.ajax.AjaxEventBehavior#onCheckEvent() will throw exception to really make developers fix the WARN message they have ignored in Wicket 7.x.
> The method has 'protected' visibility, so it could be overridden by applications which need to use custom events with 'on' prefix in their name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)