You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lawofcycles (via GitHub)" <gi...@apache.org> on 2026/09/19 17:12:45 UTC

[PR] GH-1300: Use Locale.ROOT when building C Data Interface format strings [arrow-java]

lawofcycles opened a new pull request, #1301:
URL: https://github.com/apache/arrow-java/pull/1301

   ## What's Changed
   `Format.asString` built the `FixedSizeList` (`+w:%d`), `FixedSizeBinary` (`w:%d`) and `Decimal` (`d:%d,%d[,%d]`) format strings with `String.format` and no explicit `Locale`. `java.util.Formatter` localises the digits of `%d` with the default locale, so a JVM running under `ar-EG`, `bn-BD`, `mr-IN` and similar locales exported `+w:٨` instead of `+w:8`, which arrow-rs and other implementations reject.
   
   This passes `Locale.ROOT` to the four calls and adds `FormatTest.testAsStringIgnoresDefaultLocale`, which sets the default locale to `ar-EG` for the duration of the test and asserts the ASCII output.
   
   Closes #1300.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-1300: Use Locale.ROOT when building C Data Interface format strings [arrow-java]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1301:
URL: https://github.com/apache/arrow-java/pull/1301#issuecomment-5743812807

   
   <!-- label_helper_comment -->
   Thank you for opening a pull request!
   
   Please label the PR with one or more of:
   
   - bug-fix
   - chore
   - dependencies
   - documentation
   - enhancement
   
   Also, add the 'breaking-change' label if appropriate.
   
   See [CONTRIBUTING.md](https://github.com/apache/arrow-java/blob/main/CONTRIBUTING.md) for details.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-1300: Use Locale.ROOT when building C Data Interface format strings [arrow-java]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #1301:
URL: https://github.com/apache/arrow-java/pull/1301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org