You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/12 09:05:37 UTC

[GitHub] [tvm] Hzfengsy opened a new pull request #7828: fix compiling warning in simplify_expr.h

Hzfengsy opened a new pull request #7828:
URL: https://github.com/apache/tvm/pull/7828


   I got compiling warnings by clang++ on my machine:
   ```
   In file included from /home/syfeng/tvm-upstream/src/relay/transforms/simplify_expr.cc:25:
   /home/syfeng/tvm-upstream/src/relay/transforms/simplify_expr.h:77:21: warning: loop variable 'rewrite' of type 'const std::shared_ptr<tvm::relay::DFPatternRewrite>' creates a copy from type 'const std::shared_ptr<tvm::relay::DFPatternRewrite>' [-Wrange-loop-construct]
       for (const auto rewrite : rewrites_) {
                       ^
   /home/syfeng/tvm-upstream/src/relay/transforms/simplify_expr.h:77:10: note: use reference type 'const std::shared_ptr<tvm::relay::DFPatternRewrite> &' to prevent copying
       for (const auto rewrite : rewrites_) {
            ^~~~~~~~~~~~~~~~~~~~
                       &
   ```
   
   And my compiler info :
   ```bash
   $ clang++ -v
   clang version 10.0.0-4ubuntu1
   Target: x86_64-pc-linux-gnu
   Thread model: posix
   InstalledDir: /usr/bin
   Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/9
   Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
   Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/9
   Candidate multilib: .;@m64
   Selected multilib: .;@m64
   Found CUDA installation: /usr/local/cuda-11.2, version 7.0
   ```
   
   cc @tqchen @junrushao1994 @jroesch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #7828: fix compiling warning in simplify_expr.h

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7828:
URL: https://github.com/apache/tvm/pull/7828


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen commented on pull request #7828: fix compiling warning in simplify_expr.h

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7828:
URL: https://github.com/apache/tvm/pull/7828#issuecomment-817812437


   Thanks @Hzfengsy 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org