You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/24 22:53:45 UTC

[GitHub] pracheer commented on a change in pull request #14222: Add more support for mxnet_to_coreml

pracheer commented on a change in pull request #14222: Add more support for mxnet_to_coreml
URL: https://github.com/apache/incubator-mxnet/pull/14222#discussion_r259645785
 
 

 ##########
 File path: tools/coreml/converter/_layers.py
 ##########
 @@ -361,7 +395,7 @@ def convert_convolution(net, node, module, builder):
         stride_height=stride_height,
         stride_width=stride_width,
         border_mode=border_mode,
-        groups=1,
+        groups=n_groups,
 
 Review comment:
   Is it possible to add a unit test case for this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services