You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sodonnel (via GitHub)" <gi...@apache.org> on 2026/03/26 11:36:59 UTC
[PR] HDDS-14905. Followups from HDDS-14672 [ozone]
sodonnel opened a new pull request, #9983:
URL: https://github.com/apache/ozone/pull/9983
## What changes were proposed in this pull request?
There were some "post commit" review comments on [HDDS-14672](https://issues.apache.org/jira/browse/HDDS-14672), so addressing them in this Jira. https://github.com/apache/ozone/pull/9955#pullrequestreview-3995413607
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14905
## How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14905. Followups from HDDS-14672 [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #9983:
URL: https://github.com/apache/ozone/pull/9983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14905. Followups from HDDS-14672 [ozone]
Posted by "sodonnel (via GitHub)" <gi...@apache.org>.
sodonnel commented on code in PR #9983:
URL: https://github.com/apache/ozone/pull/9983#discussion_r3009107399
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java:
##########
@@ -95,7 +94,7 @@ void replicatedFinalizationSteps(HDDSLayoutFeature lf,
@Override
public void postFinalizeUpgrade(SCMUpgradeFinalizationContext context) throws IOException {
waitForDatanodesToFinalize(context);
- getVersionManager().setUpgradeState(FINALIZATION_DONE);
+ getVersionManager().setUpgradeState(UpgradeFinalization.Status.FINALIZATION_DONE);
Review Comment:
Ah yes, I have pushed that change now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14905. Followups from HDDS-14672 [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #9983:
URL: https://github.com/apache/ozone/pull/9983#discussion_r2997896241
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java:
##########
@@ -95,7 +94,7 @@ void replicatedFinalizationSteps(HDDSLayoutFeature lf,
@Override
public void postFinalizeUpgrade(SCMUpgradeFinalizationContext context) throws IOException {
waitForDatanodesToFinalize(context);
- getVersionManager().setUpgradeState(FINALIZATION_DONE);
+ getVersionManager().setUpgradeState(UpgradeFinalization.Status.FINALIZATION_DONE);
Review Comment:
Looks we just changed the phrasing on the import here. Can we instead change this to a `super` call? [Ref](https://github.com/apache/ozone/pull/9955#discussion_r2983859477)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org