You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/03/08 12:23:02 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request, #10508: Publish Docker images on official release
kezhenxu94 opened a new pull request, #10508:
URL: https://github.com/apache/skywalking/pull/10508
As Docker images are convenient distributions for users, not Apache official release artifacts, the Apache Infra team allows us to publish the Docker images automatically on GitHub when there is a new release. I set this up to test in the coming 9.4.0 because it needs a new tag, and I keep the release doc in case it fails. After verifications, the release doc can be removed.
This is helpful for release managers to reduce some extra works, also, the Docker team has limited seats and if new release managers want to publish the images, we may run out of the seats number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10508: Publish Docker images on official release
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #10508:
URL: https://github.com/apache/skywalking/pull/10508#discussion_r1129366831
##########
docs/en/guides/How-to-release.md:
##########
@@ -282,6 +282,10 @@ SkyWalking Resources:
## Publish the Docker images
+We have a [GitHub workflow](../../../.github/workflows/publish-docker.yaml) to automatically publish the Docker images to
+Docker Hub after you set the version from `pre-release` to `release`, all you need to do is to watch that workflow and see
Review Comment:
> Do we need to post a `pre-release`? Or directly `release` works too? Usually I only save the release as draft and publish after the vote passed.
directly `release` works too. but our release process is to set `pre-release` first so I wrote the doc here to accord our process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #10508: Publish Docker images on official release
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #10508:
URL: https://github.com/apache/skywalking/pull/10508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10508: Publish Docker images on official release
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #10508:
URL: https://github.com/apache/skywalking/pull/10508#discussion_r1129366831
##########
docs/en/guides/How-to-release.md:
##########
@@ -282,6 +282,10 @@ SkyWalking Resources:
## Publish the Docker images
+We have a [GitHub workflow](../../../.github/workflows/publish-docker.yaml) to automatically publish the Docker images to
+Docker Hub after you set the version from `pre-release` to `release`, all you need to do is to watch that workflow and see
Review Comment:
> Do we need to post a `pre-release`? Or directly `release` works too? Usually I only save the release as draft and publish after the vote passed.
directly `release` works too. but our release process is to set `pre-release` first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10508: Publish Docker images on official release
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10508:
URL: https://github.com/apache/skywalking/pull/10508#discussion_r1129361836
##########
docs/en/guides/How-to-release.md:
##########
@@ -282,6 +282,10 @@ SkyWalking Resources:
## Publish the Docker images
+We have a [GitHub workflow](../../../.github/workflows/publish-docker.yaml) to automatically publish the Docker images to
+Docker Hub after you set the version from `pre-release` to `release`, all you need to do is to watch that workflow and see
Review Comment:
Do we need to post a `pre-release`? Or directly `release` works too? Usually I only save the release as draft and publish after the vote passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org