You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/10/01 14:24:06 UTC
[GitHub] [lucene] ChrisHegarty opened a new pull request #347: LUCENE-10118: Fix thread visibility issue in testMergeThreadMessages
ChrisHegarty opened a new pull request #347:
URL: https://github.com/apache/lucene/pull/347
# Description
The new test case, testMergeThreadMessages, added as part of LUCENE-10118 has been seen to fail, one time.
# Solution
There is a potential visibility issue between the thread capturing the messages and the main test thread asserting the messages. The solution is to simply use a synchronised list to guarantee visibility.
# Tests
The test case has been run several 100s of thousands of time, without failure.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #347: LUCENE-10118: Fix thread visibility issue in testMergeThreadMessages
Posted by GitBox <gi...@apache.org>.
romseygeek merged pull request #347:
URL: https://github.com/apache/lucene/pull/347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org